Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Form/DataTransformer/FieldOptionTransformer.php

Summary

Maintainability
A
25 mins
Test Coverage

Function transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function transform($fieldOptions)
    {
        $result = array();
        if (is_array($fieldOptions)) {
            foreach ($fieldOptions as $fieldOption) {
Severity: Minor
Found in Backoffice/Form/DataTransformer/FieldOptionTransformer.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Call to method getKey from undeclared class \OpenOrchestra\ModelInterface\Model\FieldOptionInterface
Open

                    $result[$fieldOption->getKey()] = $fieldOption->getValue();
Severity: Critical
Found in Backoffice/Form/DataTransformer/FieldOptionTransformer.php by phan

Class implements undeclared interface \Symfony\Component\Form\DataTransformerInterface
Open

class FieldOptionTransformer implements DataTransformerInterface
Severity: Critical
Found in Backoffice/Form/DataTransformer/FieldOptionTransformer.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\FieldOptionInterface
Open

                if($fieldOption instanceof FieldOptionInterface) {
Severity: Critical
Found in Backoffice/Form/DataTransformer/FieldOptionTransformer.php by phan

Call to method getValue from undeclared class \OpenOrchestra\ModelInterface\Model\FieldOptionInterface
Open

                    $result[$fieldOption->getKey()] = $fieldOption->getValue();
Severity: Critical
Found in Backoffice/Form/DataTransformer/FieldOptionTransformer.php by phan

Expected 1 space after IF keyword; 0 found
Open

                if($fieldOption instanceof FieldOptionInterface) {
Severity: Minor
Found in Backoffice/Form/DataTransformer/FieldOptionTransformer.php by phpcodesniffer

There are no issues that match your filters.

Category
Status