Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php

Summary

Maintainability
A
0 mins
Test Coverage

Parameter $objectManager has undeclared type \Doctrine\Common\Persistence\ObjectManager
Open

    public function __construct(EntityDbMapperInterface $entityDbMapper, ObjectManager $objectManager, $documentClass)
Severity: Minor
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phan

Parameter $entityDbMapper has undeclared type \OpenOrchestra\ModelInterface\Manager\EntityDbMapperInterface
Open

    public function __construct(EntityDbMapperInterface $entityDbMapper, ObjectManager $objectManager, $documentClass)
Severity: Minor
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phan

Call to method fromEntityToDb from undeclared class \OpenOrchestra\ModelInterface\Manager\EntityDbMapperInterface
Open

            return $this->entityDbMapper->fromEntityToDb($document);
Severity: Critical
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phan

Class implements undeclared interface \Symfony\Component\Form\DataTransformerInterface
Open

class ReferenceToEmbedTransformer implements DataTransformerInterface
Severity: Critical
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phan

Call to method fromDbToEntity from undeclared class \OpenOrchestra\ModelInterface\Manager\EntityDbMapperInterface
Open

            return array($this->formTypeName => $this->entityDbMapper->fromDbToEntity($data)->getId());
Severity: Critical
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phan

Call to method find from undeclared class \Doctrine\Common\Persistence\ObjectManager
Open

            $document = $this->objectManager->find($this->documentClass, $id);
Severity: Critical
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phan

Avoid variables with short names like $id. Configured minimum length is 3.
Open

            $id = current($data);
Severity: Minor
Found in Backoffice/Form/DataTransformer/ReferenceToEmbedTransformer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status