open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/Component/ContentChoiceType.php

Summary

Maintainability
A
0 mins
Test Coverage

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add($this->formTypeName, 'choice', array(

Call to method addModelTransformer from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addModelTransformer($this->referenceToEmbedTransformer);

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)

Reference to constant CHOICE_AND from undeclared class \OpenOrchestra\ModelInterface\Repository\ReadContentRepositoryInterface
Open

                    'choiceType' => ReadContentRepositoryInterface::CHOICE_AND,

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

Call to method findByContentTypeAndCondition from undeclared class \OpenOrchestra\ModelInterface\Repository\ContentRepositoryInterface
Open

        $contents = $this->contentRepository->findByContentTypeAndCondition($language, $contentType, $operator, $keywords, $siteId);

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class ContentChoiceType extends AbstractType

Parameter $contentRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\ContentRepositoryInterface
Open

    public function __construct(ContentRepositoryInterface $contentRepository, ContextBackOfficeInterface $contextManager, ReferenceToEmbedTransformer $referenceToEmbedTransformer, $formTypeName)

Avoid excessively long variable names like $referenceToEmbedTransformer. Keep variable name length under 20.
Open

    protected $referenceToEmbedTransformer;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $referenceToEmbedTransformer. Keep variable name length under 20.
Open

    public function __construct(ContentRepositoryInterface $contentRepository, ContextBackOfficeInterface $contextManager, ReferenceToEmbedTransformer $referenceToEmbedTransformer, $formTypeName)

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 166 characters
Open

            'choices' => $this->getChoices($options['content_search']['contentType'], $options['content_search']['choiceType'], $options['content_search']['keywords']

Line exceeds 120 characters; contains 132 characters
Open

        $contents = $this->contentRepository->findByContentTypeAndCondition($language, $contentType, $operator, $keywords, $siteId);

Line exceeds 120 characters; contains 195 characters
Open

    public function __construct(ContentRepositoryInterface $contentRepository, ContextBackOfficeInterface $contextManager, ReferenceToEmbedTransformer $referenceToEmbedTransformer, $formTypeName)

Expected 0 spaces before closing bracket; newline found
Open

            'choices' => $this->getChoices($options['content_search']['contentType'], $options['content_search']['choiceType'], $options['content_search']['keywords']

There are no issues that match your filters.

Category
Status