open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/Component/ContentSearchType.php

Summary

Maintainability
A
1 hr
Test Coverage

Method buildForm has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $newAttr = array();
        if (!is_null($options['authorize_new'])) {
            $newAttr['data-authorize-new'] = $options['authorize_new'];
Severity: Minor
Found in Backoffice/Form/Type/Component/ContentSearchType.php - About 1 hr to fix

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('keywords', 'oo_keywords_choice', array(

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('choiceType', 'oo_operator_choice', array(

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)

Parameter $contentRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\ContentRepositoryInterface
Open

    public function __construct(

Call to method addEventSubscriber from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

            $builder->addEventSubscriber(

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class ContentSearchType extends AbstractType

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('contentType', 'oo_site_content_type_choice', array(

Avoid excessively long variable names like $booleanConditionValidator. Keep variable name length under 20.
Open

    protected $booleanConditionValidator;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $booleanConditionValidator. Keep variable name length under 20.
Open

        BooleanConditionValidator $booleanConditionValidator,

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Closing parenthesis of a multi-line function call must be on a line by itself
Open

            ));

Multi-line function call not indented correctly; expected 16 spaces but found 12
Open

            ));

There are no issues that match your filters.

Category
Status