open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/Component/TinymceType.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$options'.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class TinymceType extends AbstractType

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(array(

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)

Call to method addViewTransformer from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addViewTransformer($this->bbCodeTransformer);

Parameter $BBcodeTransformer has undeclared type \Symfony\Component\Form\DataTransformerInterface
Open

    public function __construct(DataTransformerInterface $BBcodeTransformer)

The parameter $BBcodeTransformer is not named in camelCase.
Open

    public function __construct(DataTransformerInterface $BBcodeTransformer)
    {
        $this->bbCodeTransformer = $BBcodeTransformer;
    }

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The variable $BBcodeTransformer is not named in camelCase.
Open

    public function __construct(DataTransformerInterface $BBcodeTransformer)
    {
        $this->bbCodeTransformer = $BBcodeTransformer;
    }

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status