open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/Component/TreeListCollectionType.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$form'.
Open

   public function buildView(FormView $view, FormInterface $form, array $options)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Parameter $treeListCollectionTransformer has undeclared type \Symfony\Component\Form\DataTransformerInterface
Open

    public function __construct(

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

   public function buildView(FormView $view, FormInterface $form, array $options)

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

       $view->vars['configuration'] = $options['configuration'];

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class TreeListCollectionType extends AbstractType

Call to method addModelTransformer from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addModelTransformer($this->treeListCollectionTransformer);

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

   public function buildView(FormView $view, FormInterface $form, array $options)

Avoid excessively long variable names like $treeListCollectionTransformer. Keep variable name length under 20.
Open

        DataTransformerInterface $treeListCollectionTransformer

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $treeListCollectionTransformer. Keep variable name length under 20.
Open

    protected $treeListCollectionTransformer;

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Multi-line function declaration not indented correctly; expected 4 spaces but found 8
Open

        ) {

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       $view->vars['configuration'] = $options['configuration'];

Line indented incorrectly; expected 4 spaces, found 3
Open

   public function buildView(FormView $view, FormInterface $form, array $options)

Line indented incorrectly; expected at least 12 spaces, found 9
Open

         ));

Line indented incorrectly; expected at least 4 spaces, found 3
Open

   {

Closing parenthesis of a multi-line function call must be on a line by itself
Open

        ));

Line indented incorrectly; expected 4 spaces, found 3
Open

   }

There are no issues that match your filters.

Category
Status