open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Form/Type/Component/TreeListType.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$form'.
Open

    public function buildView(FormView $view, FormInterface $form, array $options)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$options'.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

       $view->vars['configuration'] = $options['configuration'][$id];

Call to method addModelTransformer from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addModelTransformer($this->treeListTransformer);

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

    public function buildView(FormView $view, FormInterface $form, array $options)

Parameter $resolver has undeclared type \Symfony\Component\OptionsResolver\OptionsResolver
Open

    public function configureOptions(OptionsResolver $resolver)

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)

Call to method setDefaults from undeclared class \Symfony\Component\OptionsResolver\OptionsResolver
Open

        $resolver->setDefaults(

Parameter $treeListTransformer has undeclared type \Symfony\Component\Form\DataTransformerInterface
Open

    public function __construct(

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class TreeListType extends AbstractType

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

    public function buildView(FormView $view, FormInterface $form, array $options)

Avoid variables with short names like $id. Configured minimum length is 3.
Open

       $id = 'default';

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Multi-line function declaration not indented correctly; expected 4 spaces but found 8
Open

        ) {

Line indented incorrectly; expected 8 spaces, found 7
Open

       }

Closing parenthesis of a multi-line function call must be on a line by itself
Open

            ));

Multi-line function call not indented correctly; expected 8 spaces but found 12
Open

            ));

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       $id = 'default';

Line indented incorrectly; expected 8 spaces, found 7
Open

       if (!is_null($options['property_path'])) {

Line indented incorrectly; expected at least 12 spaces, found 11
Open

           $id = preg_replace('/^\[(.*)\]$/', '$1', $options['property_path']);

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       $view->vars['configuration'] = $options['configuration'][$id];

Line indented incorrectly; expected at least 12 spaces, found 8
Open

        ));

There are no issues that match your filters.

Category
Status