Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/GenerateForm/Strategies/SearchStrategy.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$options'.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method findAllSpecialPage from undeclared class \OpenOrchestra\ModelInterface\Repository\NodeRepositoryInterface
Open

        $specialPages = $this->nodeRepository->findAllSpecialPage($language, $siteId);
Severity: Critical
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('value', 'text', array(
Severity: Critical
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('limit', 'integer', array(
Severity: Critical
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Parameter $nodeRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\NodeRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Parameter $block has undeclared type \OpenOrchestra\ModelInterface\Model\BlockInterface
Open

    public function support(BlockInterface $block)
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Call to method getComponent from undeclared class \OpenOrchestra\ModelInterface\Model\BlockInterface
Open

        return $this->getName() === $block->getComponent();
Severity: Critical
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('nodeId', 'choice', array(
Severity: Critical
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phan

Avoid excessively long variable names like $basicBlockConfiguration. Keep variable name length under 20.
Open

        array $basicBlockConfiguration
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phpcodesniffer

Opening brace should be on a new line
Open

    protected function getSpecialPageList() {
Severity: Minor
Found in Backoffice/GenerateForm/Strategies/SearchStrategy.php by phpcodesniffer

There are no issues that match your filters.

Category
Status