Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/GeneratePerimeter/GeneratePerimeterManager.php

Summary

Maintainability
A
0 mins
Test Coverage

Doc-block of $strategy in addStrategy contains phpdoc param type \OpenOrchestra\Backoffice\GeneratePerimeter\PerimeterStrategyInterface which is incompatible with the param type \OpenOrchestra\Backoffice\GeneratePerimeter\Strategy\GeneratePerimeterStrategyInterface declared in the signature
Open

     * @param PerimeterStrategyInterface $strategy
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phan

Avoid excessively long variable names like $perimetersConfiguration. Keep variable name length under 20.
Open

        $perimetersConfiguration = array();
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There must be one blank line after the last USE statement; 0 found;
Open

use OpenOrchestra\Backoffice\GeneratePerimeter\Strategy\GeneratePerimeterStrategyInterface;
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpcodesniffer

The static declaration must come after the visibility declaration
Open

    static public function changePathToName($path) {
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpcodesniffer

The static declaration must come after the visibility declaration
Open

    static public function changeNameToPath($name) {
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpcodesniffer

Line exceeds 120 characters; contains 121 characters
Open

            $perimeters = array_merge($perimeters, array($strategy->getType() => $strategy->generatePerimeter($siteId)));
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpcodesniffer

Opening brace should be on a new line
Open

    static public function changeNameToPath($name) {
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpcodesniffer

Opening brace should be on a new line
Open

    static public function changePathToName($path) {
Severity: Minor
Found in Backoffice/GeneratePerimeter/GeneratePerimeterManager.php by phpcodesniffer

There are no issues that match your filters.

Category
Status