Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php

Summary

Maintainability
A
55 mins
Test Coverage

Function extractContentsFromElement has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    protected function extractContentsFromElement($element, array $references = array())
    {
        if ($this->isContentSearchAttribute($element)) {
            $references[] = $element['contentId'];
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method extractContentsFromElement() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
Open

    protected function extractContentsFromElement($element, array $references = array())
    {
        if ($this->isContentSearchAttribute($element)) {
            $references[] = $element['contentId'];
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\ContentAttributeInterface
Open

            $element instanceof ContentAttributeInterface
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Parameter $bbcodeParser has undeclared type \OpenOrchestra\BBcodeBundle\Parser\BBcodeParserInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Reference to constant TAG_NAME from undeclared class \OpenOrchestra\DisplayBundle\BBcode\InternalLinkDefinition
Open

        $nodeTags = $parsedBBcode->getElementByTagName(InternalLinkDefinition::TAG_NAME);
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Parameter $contentRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\ContentRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Call to method getValue from undeclared class \OpenOrchestra\ModelInterface\Model\ContentAttributeInterface
Open

            $references = array_merge($references, $this->extractContentIdFromBBCode($element->getValue()));
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Call to method getType from undeclared class \OpenOrchestra\ModelInterface\Model\ContentAttributeInterface
Open

            && $element->getType() === 'tinymce'
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\ContentAttributeInterface
Open

        return $attributeValue instanceof ContentAttributeInterface
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Call to method parse from undeclared class \OpenOrchestra\BBcodeBundle\Parser\BBcodeParserInterface
Open

        $parsedBBcode = $this->bbcodeParser->parse($str);
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Call to method getType from undeclared class \OpenOrchestra\ModelInterface\Model\ContentAttributeInterface
Open

            && $attributeValue->getType() === 'embedded_content';
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Call to method getValue from undeclared class \OpenOrchestra\ModelInterface\Model\ContentAttributeInterface
Open

            && $this->hasInternalLinkBBCode($element->getValue())
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Reference to constant TAG_NAME from undeclared class \OpenOrchestra\DisplayBundle\BBcode\InternalLinkDefinition
Open

        $internalLinkBBCode = '/\[' . InternalLinkDefinition::TAG_NAME . '[^]]*].*?\[\/'. InternalLinkDefinition::TAG_NAME . '\]/m';
Severity: Critical
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phan

Blank line found at end of control structure
Open
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

Blank line found at end of control structure
Open
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

Blank line found at end of control structure
Open
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

Blank line found at end of control structure
Open
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

Line exceeds 120 characters; contains 132 characters
Open

        $internalLinkBBCode = '/\[' . InternalLinkDefinition::TAG_NAME . '[^]]*].*?\[\/'. InternalLinkDefinition::TAG_NAME . '\]/m';
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

Expected 0 spaces after opening bracket; newline found
Open

        } elseif (
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

Expected 0 spaces after opening bracket; newline found
Open

        } elseif (
Severity: Minor
Found in Backoffice/Reference/Strategies/AbstractContentReferenceStrategy.php by phpcodesniffer

There are no issues that match your filters.

Category
Status