Backoffice/Reference/Strategies/AbstractKeywordReferenceStrategy.php
Function extractKeywordsFromElement
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function extractKeywordsFromElement($element, array $references = array())
{
if ($this->isKeywordsConditionAttribute($element)) {
$keywordIds = $this->extractKeywordIdsFromConditionAttribute($element);
foreach ($keywordIds as $keywordId) {
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Call to method getKeywords
from undeclared class \OpenOrchestra\ModelInterface\Model\KeywordableInterface
Open
Open
$keywords = $entity->getKeywords();
- Create a ticketCreate a ticket
- Exclude checks
Parameter $keywordRepository
has undeclared type \OpenOrchestra\ModelInterface\Repository\KeywordRepositoryInterface
Open
Open
public function __construct(KeywordRepositoryInterface $keywordRepository)
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant OPERATOR_SPLIT
from undeclared class \OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface
Open
Open
$patterns = explode('|', KeywordableTraitInterface::OPERATOR_SPLIT);
- Create a ticketCreate a ticket
- Exclude checks
Parameter $entity
has undeclared type \OpenOrchestra\ModelInterface\Model\KeywordableInterface
Open
Open
protected function extractKeywordsFromKeywordableEntity(KeywordableInterface $entity)
- Create a ticketCreate a ticket
- Exclude checks
Avoid excessively long variable names like $conditionWithoutOperator. Keep variable name length under 20. Open
Open
$conditionWithoutOperator = preg_replace($patterns, ' ', $condition);
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}