Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php

Summary

Maintainability
A
50 mins
Test Coverage

Function addReferencesToEntity has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function addReferencesToEntity($entity)
    {
        if ($this->support($entity)) {
            $keywordIds = $this->extractKeywordsFromContentType($entity);
Severity: Minor
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function extractKeywordsFromContentType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function extractKeywordsFromContentType(ContentTypeInterface $contentType)
    {
        $keywordIds = array();
        $fields = $contentType->getFields();
Severity: Minor
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                $keyword->removeUseInEntity($contentTypeId, ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phan

Call to method getFields from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $fields = $contentType->getFields();
Severity: Critical
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                ->findByUsedInEntity($contentTypeId, ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        return $entity instanceof ContentTypeInterface;
Severity: Critical
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phan

Parameter $contentType has undeclared type \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

    protected function extractKeywordsFromContentType(ContentTypeInterface $contentType)
Severity: Minor
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                    $keyword->addUseInEntity($entity->getContentTypeId(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phan

Avoid excessively long variable names like $keywordsUsedInContentType. Keep variable name length under 20.
Open

            $keywordsUsedInContentType = $this->keywordRepository
Severity: Minor
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 122 characters
Open

class KeywordInContentTypeReferenceStrategy extends AbstractKeywordReferenceStrategy implements ReferenceStrategyInterface
Severity: Minor
Found in Backoffice/Reference/Strategies/KeywordInContentTypeReferenceStrategy.php by phpcodesniffer

There are no issues that match your filters.

Category
Status