Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Security/Authorization/Voter/ContentVoter.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$action'.
Open

    protected function voteForOwnedSubject($action, $content, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Parameter $token has undeclared type \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

    protected function voteForReadAction($subject, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Parameter $token has undeclared type \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

    protected function voteForOwnedSubject($action, $content, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

            && $this->isSubjectInPerimeter($content->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Call to method getContentType from undeclared class \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

            $contentType = $subject->getContentType();
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Parameter $subject has undeclared type \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

    protected function voteForReadAction($subject, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Parameter $content has undeclared type \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

    protected function voteForOwnedSubject($action, $content, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        return $this->isSubjectInPerimeter($contentType, $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Call to method getUser from undeclared class \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

            && $this->isSubjectInPerimeter($subject->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Parameter $subject has undeclared type \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

    protected function voteForSomeoneElseSubject($action, $subject, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Call to method getUser from undeclared class \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

        return $this->isSubjectInPerimeter($contentType, $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Call to method getContentType from undeclared class \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

            && $this->isSubjectInPerimeter($subject->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Call to method getUser from undeclared class \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

            && $this->isSubjectInPerimeter($content->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

            && $this->isSubjectInPerimeter($subject->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

        return $subject === ContentInterface::ENTITY_TYPE;
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Parameter $token has undeclared type \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

    protected function voteForSomeoneElseSubject($action, $subject, TokenInterface $token)
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Call to method getContentType from undeclared class \OpenOrchestra\ModelInterface\Model\ContentInterface
Open

            && $this->isSubjectInPerimeter($content->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Critical
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phan

Terminating statement must be indented to the same level as the CASE body
Open

            break;
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phpcodesniffer

Terminating statement must be indented to the same level as the CASE body
Open

            break;
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phpcodesniffer

Line exceeds 120 characters; contains 125 characters
Open

            && $this->isSubjectInPerimeter($content->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phpcodesniffer

Line exceeds 120 characters; contains 125 characters
Open

            && $this->isSubjectInPerimeter($subject->getContentType(), $token->getUser(), ContentTypeInterface::ENTITY_TYPE);
Severity: Minor
Found in Backoffice/Security/Authorization/Voter/ContentVoter.php by phpcodesniffer

There are no issues that match your filters.

Category
Status