Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php

Summary

Maintainability
A
0 mins
Test Coverage

The class NodeStrategyTest has 11 public methods. Consider refactoring NodeStrategyTest to keep number of public methods under 10.
Open

class NodeStrategyTest extends AbstractBaseTestCase
{
    protected $nodeRepository;
    protected $strategy;
    protected $mainUrlArguments = array(
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Avoid using static access to class '\Phake' in method 'provideDeleteVersionNode'.
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideEditNode'.
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testCanDelete'.
Open

        Phake::when($this->nodeRepository)->countByParentId(Phake::anyParameters())->thenReturn($countByParentId);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideCanChangeToPublishStatus'.
Open

        $block = Phake::mock('OpenOrchestra\ModelInterface\Model\BlockInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testCanDelete'.
Open

        Phake::when($this->nodeRepository)->hasNodeIdWithoutAutoUnpublishToState(Phake::anyParameters())->thenReturn($isWithoutAutoUnpublishToState);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideDeleteVersionNode'.
Open

        $status1 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideDeleteNode'.
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testCanDeleteVersion'.
Open

        Phake::when($this->nodeRepository)->countNotDeletedVersions(Phake::anyParameters())->thenReturn($nbrVersions);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideDeleteVersionNode'.
Open

        $status0 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideEditNode'.
Open

        $status0 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideEditNode'.
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideCanChangeToPublishStatus'.
Open

        $status = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideCanChangeToPublishStatus'.
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->generateFormManager = Phake::mock('OpenOrchestra\BackofficeBundle\StrategyManager\GenerateFormManager');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideEditNode'.
Open

        $status1 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideDeleteNode'.
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideCanChangeToPublishStatus'.
Open

        $area = Phake::mock('OpenOrchestra\ModelInterface\Model\AreaInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideDeleteVersionNode'.
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'provideCanChangeToPublishStatus'.
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->nodeRepository = Phake::mock('OpenOrchestra\ModelInterface\Repository\NodeRepositoryInterface');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        Phake::when($this->generateFormManager)->getRequiredUriParameter(Phake::anyParameters())->thenReturn($this->mainUrlArguments);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method mock from undeclared class \Phake
Open

        $this->generateFormManager = Phake::mock('OpenOrchestra\BackofficeBundle\StrategyManager\GenerateFormManager');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node1)->getStatus()->thenReturn($status1);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->countByParentId(Phake::anyParameters())->thenReturn($countByParentId);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node1)->getNodeId()->thenReturn('fakeNodeId1');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->nodeRepository = Phake::mock('OpenOrchestra\ModelInterface\Repository\NodeRepositoryInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Reference to undeclared property \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest->generateFormManager
Open

        Phake::when($this->generateFormManager)->getRequiredUriParameter(Phake::anyParameters())->thenReturn($this->mainUrlArguments);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertSame
Open

        $this->assertSame($isGranted, $this->strategy->canDelete($node, array()));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Parameter $node has undeclared type \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

    public function testCanEdit(NodeInterface $node, $isGranted)
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertSame
Open

        $this->assertSame($isGranted, $this->strategy->canEdit($node, array()));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($status0)->isBlockedEdition()->thenReturn(false);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Parameter $node has undeclared type \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

    public function testCanDelete(NodeInterface $node, $isWithoutAutoUnpublishToState, $countByParentId, $isGranted)
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node0)->getNodeId()->thenReturn(NodeInterface::ROOT_NODE_ID);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node1)->getStatus()->thenReturn($status);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Reference to undeclared property \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest->generateFormManager
Open

        $this->strategy = new NodeStrategy($this->nodeRepository, $this->generateFormManager);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node0)->getStatus()->thenReturn($status0);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->hasNodeIdWithoutAutoUnpublishToState(Phake::anyParameters())->thenReturn($isWithoutAutoUnpublishToState);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $status0 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $status1 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $status1 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node1)->getStatus()->thenReturn($status1);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->countByParentId(Phake::anyParameters())->thenReturn($countByParentId);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($status1)->isPublishedState()->thenReturn(true);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertSame
Open

        $this->assertSame($isGranted, $this->strategy->canChangeStatus($node, array()));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->hasNodeIdWithoutAutoUnpublishToState(Phake::anyParameters())->thenReturn($isWithoutAutoUnpublishToState);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $area = Phake::mock('OpenOrchestra\ModelInterface\Model\AreaInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node0)->getRoutePattern()->thenReturn('');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertEquals
Open

        $this->assertEquals(NodeInterface::ENTITY_TYPE, $this->strategy->getType());
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->countNotDeletedVersions(Phake::anyParameters())->thenReturn($nbrVersions);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($status)->isPublishedState()->thenReturn(array(true));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $status0 = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertSame
Open

        $this->assertSame($isGranted, $this->strategy->canChangeToPublishStatus($node, array()));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Parameter $node has undeclared type \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

    public function testCanChangeStatus(NodeInterface $node, $isGranted)
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($area)->getBlocks()->thenReturn(array($block));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

        $this->assertEquals(NodeInterface::ENTITY_TYPE, $this->strategy->getType());
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($status1)->isBlockedEdition()->thenReturn(true);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($status0)->isPublishedState()->thenReturn(false);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node0)->getStatus()->thenReturn($status0);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Parameter $node has undeclared type \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

    public function testCanChangeToPublishStatus(NodeInterface $node, $isGranted)
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node0)->getAreas()->thenReturn(array($area));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node0)->getStatus()->thenReturn($status);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Reference to undeclared property \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest->generateFormManager
Open

        $this->generateFormManager = Phake::mock('OpenOrchestra\BackofficeBundle\StrategyManager\GenerateFormManager');
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Reference to constant ROOT_NODE_ID from undeclared class \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

        Phake::when($node0)->getNodeId()->thenReturn(NodeInterface::ROOT_NODE_ID);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Parameter $node has undeclared type \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

    public function testCanDeleteVersion(NodeInterface $node, $nbrVersions, $isGranted)
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->countNotDeletedVersions(Phake::anyParameters())->thenReturn($nbrVersions);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $block = Phake::mock('OpenOrchestra\ModelInterface\Model\BlockInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node0 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $status = Phake::mock('OpenOrchestra\ModelInterface\Model\StatusInterface');
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node1)->getAreas()->thenReturn(array($area));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertEquals
Open

        $this->assertEquals(array(
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class NodeStrategyTest extends AbstractBaseTestCase
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->generateFormManager)->getRequiredUriParameter(Phake::anyParameters())->thenReturn($this->mainUrlArguments);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->generateFormManager)->getRequiredUriParameter(Phake::anyParameters())->thenReturn($this->mainUrlArguments);
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to undeclared method \OpenOrchestra\BackOffice\Tests\BusinessRules\Strategies\NodeStrategyTest::assertSame
Open

        $this->assertSame($isGranted, $this->strategy->canDeleteVersion($node, array()));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($node1)->getRoutePattern()->thenReturn(implode($mainUrlArguments));
Severity: Critical
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phan

Avoid excessively long variable names like $isWithoutAutoUnpublishToState. Keep variable name length under 20.
Open

    public function testCanDelete(NodeInterface $node, $isWithoutAutoUnpublishToState, $countByParentId, $isGranted)
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 134 characters
Open

        Phake::when($this->generateFormManager)->getRequiredUriParameter(Phake::anyParameters())->thenReturn($this->mainUrlArguments);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpcodesniffer

Line exceeds 120 characters; contains 149 characters
Open

        Phake::when($this->nodeRepository)->hasNodeIdWithoutAutoUnpublishToState(Phake::anyParameters())->thenReturn($isWithoutAutoUnpublishToState);
Severity: Minor
Found in Backoffice/Tests/BusinessRules/Strategies/NodeStrategyTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status