Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Method testPreSetData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function testPreSetData($id, $edit, $new)
    {
        $choices = array(
            'default' => 'default',
            'full_page' => 'full_page',
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php - About 1 hr to fix

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->node = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->form = Phake::mock('Symfony\Component\Form\FormBuilder');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSetData'.
Open

        Phake::verify($this->event->getForm(), Phake::times($edit))->add('template', 'choice', array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        Phake::when($this->form)->add(Phake::anyParameters())->thenReturn($this->form);
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSetData'.
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('nodeTemplateSelection', 'form', array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->event = Phake::mock('Symfony\Component\Form\FormEvent');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->nodeManager = Phake::mock('OpenOrchestra\Backoffice\Manager\NodeManager');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSetData'.
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('nodeSource', 'oo_node_choice', array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSubmit'.
Open

        Phake::verify($this->nodeManager, Phake::times($nbrCall))->hydrateNodeFromNodeId(Phake::anyParameters());
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSetData'.
Open

        Phake::when($this->form)->get(Phake::anyParameters())->thenReturn($this->form);
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSetData'.
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('template', 'choice', array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $site = Phake::mock('OpenOrchestra\ModelInterface\Model\SiteInterface');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->templateManager = Phake::mock('OpenOrchestra\Backoffice\Manager\TemplateManager');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSubmit'.
Open

        Phake::verify($this->nodeManager, Phake::times($nbrCall))->hydrateNodeFromNodeId(Phake::anyParameters());
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->contextManager = Phake::mock('OpenOrchestra\Backoffice\Context\ContextBackOfficeInterface');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->siteRepository = Phake::mock('OpenOrchestra\ModelInterface\Repository\SiteRepositoryInterface');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method when from undeclared class \Phake
Open

        Phake::when($this->form)->get(Phake::anyParameters())->thenReturn($this->form);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->templateManager)->getTemplateSetParameters()->thenReturn(array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->node)->getId()->thenReturn($id);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method verify from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('nodeSource', 'oo_node_choice', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->form)->getData()->thenReturn($this->node);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method verify from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('template', 'choice', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\EventSubscriber\NodeTemplateSelectionSubscriberTest::assertArrayHasKey
Open

        $this->assertArrayHasKey(FormEvents::PRE_SUBMIT, $this->subscriber->getSubscribedEvents());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Reference to constant PRE_SET_DATA from undeclared class \Symfony\Component\Form\FormEvents
Open

        $this->assertArrayHasKey(FormEvents::PRE_SET_DATA, $this->subscriber->getSubscribedEvents());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->contextManager = Phake::mock('OpenOrchestra\Backoffice\Context\ContextBackOfficeInterface');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->templateManager = Phake::mock('OpenOrchestra\Backoffice\Manager\TemplateManager');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method verify from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('nodeTemplateSelection', 'form', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->event = Phake::mock('Symfony\Component\Form\FormEvent');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method verify from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($edit))->add('template', 'choice', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->event)->getData()->thenReturn($data);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method times from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('nodeSource', 'oo_node_choice', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method times from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('nodeTemplateSelection', 'form', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->node)->getId()->thenReturn($id);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->form = Phake::mock('Symfony\Component\Form\FormBuilder');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->node = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->event)->getData()->thenReturn($this->node);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method times from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($new))->add('template', 'choice', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $site = Phake::mock('OpenOrchestra\ModelInterface\Model\SiteInterface');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\EventSubscriber\NodeTemplateSelectionSubscriberTest::assertInstanceOf
Open

        $this->assertInstanceOf('Symfony\Component\EventDispatcher\EventSubscriberInterface', $this->subscriber);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\EventSubscriber\NodeTemplateSelectionSubscriberTest::assertArrayHasKey
Open

        $this->assertArrayHasKey(FormEvents::PRE_SET_DATA, $this->subscriber->getSubscribedEvents());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->form)->get(Phake::anyParameters())->thenReturn($this->form);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->form)->add(Phake::anyParameters())->thenReturn($this->form);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method verify from undeclared class \Phake
Open

        Phake::verify($this->nodeManager, Phake::times($nbrCall))->hydrateNodeFromNodeId(Phake::anyParameters());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($site)->getTemplateSet()->thenReturn($this->templateSet);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->contextManager)->getSiteId()->thenReturn($this->siteId);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method times from undeclared class \Phake
Open

        Phake::verify($this->event->getForm(), Phake::times($edit))->add('template', 'choice', array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Reference to constant PRE_SUBMIT from undeclared class \Symfony\Component\Form\FormEvents
Open

        $this->assertArrayHasKey(FormEvents::PRE_SUBMIT, $this->subscriber->getSubscribedEvents());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::verify($this->nodeManager, Phake::times($nbrCall))->hydrateNodeFromNodeId(Phake::anyParameters());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method times from undeclared class \Phake
Open

        Phake::verify($this->nodeManager, Phake::times($nbrCall))->hydrateNodeFromNodeId(Phake::anyParameters());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->form)->add(Phake::anyParameters())->thenReturn($this->form);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->siteRepository = Phake::mock('OpenOrchestra\ModelInterface\Repository\SiteRepositoryInterface');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->event)->getForm()->thenReturn($this->form);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->nodeManager = Phake::mock('OpenOrchestra\Backoffice\Manager\NodeManager');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->siteRepository)->findOneBySiteId($this->siteId)->thenReturn($site);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class NodeTemplateSelectionSubscriberTest extends AbstractBaseTestCase
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phan

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function testPreSubmit($data, $id, $nbrCall)
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function testPreSetData($id, $edit, $new)
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/NodeTemplateSelectionSubscriberTest.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status