Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php

Summary

Maintainability
A
1 hr
Test Coverage

Method provideEvent has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function provideEvent()
    {
        $formData0 = new ArrayCollection(array(
            'order0' => true,
            'order1' => true,
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php - About 1 hr to fix

Avoid using static access to class '\Phake' in method 'testPreSubmit'.
Open

        $config = Phake::mock('Symfony\Component\Form\FormConfigInterface');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSubmit'.
Open

        $event = Phake::mock('Symfony\Component\Form\FormEvent');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testPreSubmit'.
Open

        $eventDispatcher = Phake::mock('Symfony\Component\EventDispatcher\EventDispatcherInterface');
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method mock from undeclared class \Phake
Open

        $event = Phake::mock('Symfony\Component\Form\FormEvent');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($event)->getData()->thenReturn($data);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Possibly zero references to use statement for classlike/namespace FormEvent (\Symfony\Component\Form\FormEvent)
Open

use Symfony\Component\Form\FormEvent;
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class SortableCollectionSubscriberTest extends AbstractBaseTestCase
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($config)->getModelTransformers()->thenReturn(array());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($event)->getForm()->thenReturn($form);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $eventDispatcher = Phake::mock('Symfony\Component\EventDispatcher\EventDispatcherInterface');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method getData from undeclared class \Symfony\Component\Form\Form
Open

        $newData = $form->getData();
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($config)->getEventDispatcher()->thenReturn($eventDispatcher);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $config = Phake::mock('Symfony\Component\Form\FormConfigInterface');
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method setData from undeclared class \Symfony\Component\Form\Form
Open

        $form->setData($formData);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\EventSubscriber\SortableCollectionSubscriberTest::assertInstanceOf
Open

        $this->assertInstanceOf('Symfony\Component\EventDispatcher\EventSubscriberInterface', $this->subscriber);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Reference to constant PRE_SUBMIT from undeclared class \Symfony\Component\Form\FormEvents
Open

        $this->assertArrayHasKey(FormEvents::PRE_SUBMIT, $this->subscriber->getSubscribedEvents());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\EventSubscriber\SortableCollectionSubscriberTest::assertEquals
Open

        $this->assertEquals($expectedOrder, array_keys($newData));
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method __construct from undeclared class \Symfony\Component\Form\Form
Open

        $form = new Form($config);
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to method __construct from undeclared class \Doctrine\Common\Collections\ArrayCollection
Open

        $formData0 = new ArrayCollection(array(
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\EventSubscriber\SortableCollectionSubscriberTest::assertArrayHasKey
Open

        $this->assertArrayHasKey(FormEvents::PRE_SUBMIT, $this->subscriber->getSubscribedEvents());
Severity: Critical
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phan

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       $data1 = array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       ));
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       return array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       $expectedOrder = array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       );
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       );
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       );
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       );
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       $data0 = array(
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

Line indented incorrectly; expected at least 8 spaces, found 7
Open

       );
Severity: Minor
Found in Backoffice/Tests/EventSubscriber/SortableCollectionSubscriberTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status