Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->suppressSpecialCharacterHelper = Phake::mock('OpenOrchestra\ModelInterface\Helper\SuppressSpecialCharacterHelperInterface');
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\ChoicesOptionToArrayTransformerTest::assertSame
Open

        $this->assertSame($transformData, $this->transformer->transform($data));
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\ChoicesOptionToArrayTransformerTest::assertInstanceOf
Open

        $this->assertInstanceOf('Symfony\Component\Form\DataTransformerInterface', $this->transformer);
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\ChoicesOptionToArrayTransformerTest::assertSame
Open

        $this->assertSame(null, $this->transformer->reverseTransform($data));
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('choice2', array('_','.'))->thenReturn('choice2');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('translate.choice_1', array('_','.'))->thenReturn('translate.choice_1');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('translate.choîce@=!_2', array('_','.'))->thenReturn('translate.choice_2');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->suppressSpecialCharacterHelper = Phake::mock('OpenOrchestra\ModelInterface\Helper\SuppressSpecialCharacterHelperInterface');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\ChoicesOptionToArrayTransformerTest::assertSame
Open

        $this->assertSame($transformData, $this->transformer->reverseTransform($data));
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class ChoicesOptionToArrayTransformerTest extends AbstractBaseTestCase
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Argument 1 (arrayChoices) is null but \OpenOrchestra\Backoffice\Form\DataTransformer\ChoicesOptionToArrayTransformer::transform() takes array defined at /code/Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php:28
Open

        $this->assertSame('', $this->transformer->transform(null));
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\ChoicesOptionToArrayTransformerTest::assertSame
Open

        $this->assertSame('', $this->transformer->transform(null));
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('choice', array('_','.'))->thenReturn('choice');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('choîce@=!', array('_','.'))->thenReturn('choice');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('', array('_','.'))->thenReturn('');
Severity: Critical
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phan

Avoid excessively long variable names like $suppressSpecialCharacterHelper. Keep variable name length under 20.
Open

    protected $suppressSpecialCharacterHelper;
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 142 characters
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('translate.choice_1', array('_','.'))->thenReturn('translate.choice_1');
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('choîce@=!', array('_','.'))->thenReturn('choice');
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpcodesniffer

Line exceeds 120 characters; contains 146 characters
Open

        Phake::when($this->suppressSpecialCharacterHelper)->transform('translate.choîce@=!_2', array('_','.'))->thenReturn('translate.choice_2');
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpcodesniffer

Line exceeds 120 characters; contains 139 characters
Open

        $this->suppressSpecialCharacterHelper = Phake::mock('OpenOrchestra\ModelInterface\Helper\SuppressSpecialCharacterHelperInterface');
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpcodesniffer

Opening brace should be on a new line
Open

    public function testReverseTransformWithStringData($data, $transformData){
Severity: Minor
Found in Backoffice/Tests/Form/DataTransformer/ChoicesOptionToArrayTransformerTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status