open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/Tests/Form/DataTransformer/VideoUrlToIdTransformerTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$id'.
Open

    public function testResverseTransform($url, $id)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$url'.
Open

    public function testResverseTransform($url, $id)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\VideoUrlToIdTransformerTest::assertSame
Open

        $this->assertSame($url, $this->transformer->transform($url));

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\VideoUrlToIdTransformerTest::assertInstanceOf
Open

        $this->assertInstanceOf('Symfony\Component\Form\DataTransformerInterface', $this->transformer);

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\DataTransformer\VideoUrlToIdTransformerTest::assertSame
Open

        $this->assertSame($videoId, $this->transformer->reverseTransform($videoId));

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class VideoUrlToIdTransformerTest extends AbstractBaseTestCase

Avoid variables with short names like $id. Configured minimum length is 3.
Open

    public function testResverseTransform($url, $id)

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Line exceeds 120 characters; contains 207 characters
Open

            array('http://www.dailymotion.com/video/x2ec4jf_francois-fillon-deplore-une-polemique-detestable-autour-du-fn_news', 'x2ec4jf_francois-fillon-deplore-une-polemique-detestable-autour-du-fn_news'),

There are no issues that match your filters.

Category
Status