Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Phake' in method 'testConfigureOptions'.
Open

        $resolver = Phake::mock('Symfony\Component\OptionsResolver\OptionsResolver');
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $currentSiteManager = Phake::mock('OpenOrchestra\Backoffice\Context\ContextBackOfficeInterface');
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'testConfigureOptions'.
Open

        Phake::when($this->nodeRepository)->findTreeNode(Phake::anyParameters())->thenReturn(
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->node2 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Phake' in method 'setUp'.
Open

        $this->nodeRepository = Phake::mock('OpenOrchestra\ModelInterface\Repository\NodeRepositoryInterface');
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method verify from undeclared class \Phake
Open

        Phake::verify($resolver)->setDefaults(
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->node2 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\Type\Component\NodeChoiceTypeTest::assertInstanceOf
Open

        $this->assertInstanceOf('Symfony\Component\Form\AbstractType', $this->orchestraNodeChoiceType);
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\Type\Component\NodeChoiceTypeTest::assertEquals
Open

        $this->assertEquals('oo_node_choice', $this->orchestraNodeChoiceType->getName());
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $resolver = Phake::mock('Symfony\Component\OptionsResolver\OptionsResolver');
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->node1)->getName()->thenReturn($this->nodeName1);
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->node1 = Phake::mock('OpenOrchestra\ModelInterface\Model\NodeInterface');
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->node2)->getName()->thenReturn($this->nodeName2);
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Parameter $options has undeclared type \Symfony\Component\OptionsResolver\Options
Open

                'choices' => function(Options $options) {
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $currentSiteManager = Phake::mock('OpenOrchestra\Backoffice\Context\ContextBackOfficeInterface');
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->node1)->getNodeId()->thenReturn($this->nodeNodeId1);
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->node2)->getNodeId()->thenReturn($this->nodeNodeId2);
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method when from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->findTreeNode(Phake::anyParameters())->thenReturn(
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Suspicious array access to \Symfony\Component\OptionsResolver\Options
Open

                    return $this->getChoices($options['siteId']);
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\Type\Component\NodeChoiceTypeTest::getChoices
Open

                    return $this->getChoices($options['siteId']);
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method mock from undeclared class \Phake
Open

        $this->nodeRepository = Phake::mock('OpenOrchestra\ModelInterface\Repository\NodeRepositoryInterface');
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open

class NodeChoiceTypeTest extends AbstractBaseTestCase
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to method anyParameters from undeclared class \Phake
Open

        Phake::when($this->nodeRepository)->findTreeNode(Phake::anyParameters())->thenReturn(
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Tests\Form\Type\Component\NodeChoiceTypeTest::assertEquals
Open

        $this->assertEquals('choice', $this->orchestraNodeChoiceType->getParent());
Severity: Critical
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phan

Avoid excessively long variable names like $orchestraNodeChoiceType. Keep variable name length under 20.
Open

    protected $orchestraNodeChoiceType;
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Expected 1 space after FUNCTION keyword; 0 found
Open

                'choices' => function(Options $options) {
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpcodesniffer

Closing parenthesis of a multi-line function call must be on a line by itself
Open

        ));
Severity: Minor
Found in Backoffice/Tests/Form/Type/Component/NodeChoiceTypeTest.php by phpcodesniffer

There are no issues that match your filters.

Category
Status