Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
GroupBundle/Form/DataTransformer/GroupRoleTransformer.php

Summary

Maintainability
A
1 hr
Test Coverage

Function transform has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function transform($value)
    {
        foreach ($this->groupRolesConfiguration as $tables) {
            foreach ($tables as $package => $rows) {
                foreach ($rows as $row => $roles) {
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using undefined variables such as '$result' which will lead to PHP notices.
Open

                        $result[$package][$row][$role] = is_array($value) ? in_array($role, $value) : false;
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$result' which will lead to PHP notices.
Open

        return array('roles_collections' => $result);
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid unused local variables such as '$configuration'.
Open

                    foreach ($roles as $role => $configuration) {
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Class implements undeclared interface \Symfony\Component\Form\DataTransformerInterface
Open

class GroupRoleTransformer implements DataTransformerInterface
Severity: Critical
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phan

Variable $result was undeclared, but array fields are being added to it.
Open

                        $result[$package][$row][$role] = is_array($value) ? in_array($role, $value) : false;
Severity: Info
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phan

Avoid excessively long variable names like $groupRolesConfiguration. Keep variable name length under 20.
Open

        array $groupRolesConfiguration
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $groupRolesConfiguration. Keep variable name length under 20.
Open

    protected $groupRolesConfiguration;
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Expected 1 space after FUNCTION keyword; 0 found
Open

            array_walk_recursive($value, function($item, $key) use (&$result) {
Severity: Minor
Found in GroupBundle/Form/DataTransformer/GroupRoleTransformer.php by phpcodesniffer

There are no issues that match your filters.

Category
Status