Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
GroupBundle/Form/Type/GroupElementType.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$options'.
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$form'.
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('group', 'radio', array(
Severity: Critical
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

            $view->vars['parameters'] = array(
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class GroupElementType extends AbstractType
Severity: Critical
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Parameter $multiLanguagesChoiceManager has undeclared type \OpenOrchestra\ModelInterface\Manager\MultiLanguagesChoiceManagerInterface
Open

    public function __construct(
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Parameter $form has undeclared type \Symfony\Component\Form\FormInterface
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['parameters'] = array(
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Parameter $view has undeclared type \Symfony\Component\Form\FormView
Open

    public function buildView(FormView $view, FormInterface $form, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Call to method choose from undeclared class \OpenOrchestra\ModelInterface\Manager\MultiLanguagesChoiceManagerInterface
Open

                'groupName' => $this->multiLanguagesChoiceManager->choose($group->getLabels()),
Severity: Critical
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Parameter $authorizationChecker has undeclared type \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
Open

    public function __construct(
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Call to undeclared method \OpenOrchestra\Backoffice\Repository\GroupRepositoryInterface::find
Open

        $group = $this->groupRepository->find($groupId);
Severity: Critical
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Call to method isGranted from undeclared class \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
Open

                'disabled' => !$this->authorizationChecker->isGranted(ContributionActionInterface::READ, $group),
Severity: Critical
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $view->vars['checked'] = true;
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Reference to instance property vars from undeclared class \Symfony\Component\Form\FormView
Open

        $groupId = $view->vars['name'];
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phan

Avoid excessively long variable names like $multiLanguagesChoiceManager. Keep variable name length under 20.
Open

    protected $multiLanguagesChoiceManager;
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $multiLanguagesChoiceManager. Keep variable name length under 20.
Open

        MultiLanguagesChoiceManagerInterface $multiLanguagesChoiceManager,
Severity: Minor
Found in GroupBundle/Form/Type/GroupElementType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status