Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
GroupBundle/Form/Type/GroupListType.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$options'.
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupListType.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method addModelTransformer from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->addModelTransformer($this->groupListToArrayTransformer);
Severity: Critical
Found in GroupBundle/Form/Type/GroupListType.php by phan

Parameter $builder has undeclared type \Symfony\Component\Form\FormBuilderInterface
Open

    public function buildForm(FormBuilderInterface $builder, array $options)
Severity: Minor
Found in GroupBundle/Form/Type/GroupListType.php by phan

Call to method add from undeclared class \Symfony\Component\Form\FormBuilderInterface
Open

        $builder->add('groups_collection', 'collection', array(
Severity: Critical
Found in GroupBundle/Form/Type/GroupListType.php by phan

Class extends undeclared class \Symfony\Component\Form\AbstractType
Open

class GroupListType extends AbstractType
Severity: Critical
Found in GroupBundle/Form/Type/GroupListType.php by phan

Avoid excessively long variable names like $groupListToArrayTransformer. Keep variable name length under 20.
Open

        GroupListToArrayTransformer $groupListToArrayTransformer
Severity: Minor
Found in GroupBundle/Form/Type/GroupListType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $groupListToArrayTransformer. Keep variable name length under 20.
Open

    protected $groupListToArrayTransformer;
Severity: Minor
Found in GroupBundle/Form/Type/GroupListType.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status