Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
UserAdminBundle/Security/OrchestraUserChecker.php

Summary

Maintainability
A
0 mins
Test Coverage

Parameter $user has undeclared type \Symfony\Component\Security\Core\User\UserInterface
Open

    public function checkPreAuth(UserInterface $user)
Severity: Minor
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Call with 1 arg(s) to \OpenOrchestra\UserAdminBundle\Exception\NoRolesException::__construct() which only takes 0 arg(s) defined at /code/UserAdminBundle/Exception/NoRolesException.php:10
Open

            $ex = new NoRolesException('Account has not access');
Severity: Info
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Call to undeclared method \OpenOrchestra\UserAdminBundle\Exception\NoRolesException::setUser
Open

            $ex->setUser($user);
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Call to method getRoles from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        $roles = $user->getRoles();
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Checking instanceof against undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

        if (!$user instanceof OrchestraUserInterface) {
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Class extends undeclared class \Symfony\Component\Security\Core\User\UserChecker
Open

class OrchestraUserChecker extends UserChecker
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Reference to undeclared class \Symfony\Component\Security\Core\User\UserChecker
Open

        parent::checkPreAuth($user);
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Reference to constant ROLE_DEFAULT from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

            (1 === count($roles) && $user->hasRole(OrchestraUserInterface::ROLE_DEFAULT))
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Call to method hasRole from undeclared class \OpenOrchestra\UserBundle\Model\UserInterface
Open

            (1 === count($roles) && $user->hasRole(OrchestraUserInterface::ROLE_DEFAULT))
Severity: Critical
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phan

Avoid variables with short names like $ex. Configured minimum length is 3.
Open

            $ex = new NoRolesException('Account has not access');
Severity: Minor
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Expected 0 spaces after opening bracket; newline found
Open

        if (
Severity: Minor
Found in UserAdminBundle/Security/OrchestraUserChecker.php by phpcodesniffer

There are no issues that match your filters.

Category
Status