open-orchestra/open-orchestra-user-bundle

View on GitHub

Showing 3 of 3 total issues

Function process has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function process(ContainerBuilder $container)
    {
        $resourcePath = '.';
        foreach ($container->getResources() as $resource) {
            if (!$resource instanceof FileResource) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate($value, Constraint $constraint)
    {
        $newPassword = $this->context->getRoot()->get('plainPassword')->getViewData();
        if ($this->context->getRoot()->has('current_password')) {
            $currentPassword = $this->context->getRoot()->get('current_password')->getData();
Severity: Minor
Found in UserBundle/Validator/Constraints/ComplexUserPasswordValidator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function validate($value, Constraint $constraint)
    {
        $newPassword = $this->context->getRoot()->get('plainPassword')->getViewData();
        if ($this->context->getRoot()->has('current_password')) {
            $currentPassword = $this->context->getRoot()->get('current_password')->getData();
Severity: Minor
Found in UserBundle/Validator/Constraints/ComplexUserPasswordValidator.php - About 1 hr to fix
Severity
Category
Status
Source
Language