Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_career_transition/models/hr_career_transition.py

Summary

Maintainability
F
1 wk
Test Coverage

File hr_career_transition.py has 734 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright 2018 OpenSynergy Indonesia
# Copyright 2020 PT. Simetri Sinergi Indonesia
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
Severity: Major
Found in hr_career_transition/models/hr_career_transition.py - About 1 day to fix

    HrCareerTransition has 43 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class HrCareerTransition(models.Model):
    _name = "hr.career_transition"
    _description = "Career Transition"
    _inherit = [
        "mail.thread",
    Severity: Minor
    Found in hr_career_transition/models/hr_career_transition.py - About 5 hrs to fix

      Function _prepare_contract_update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def _prepare_contract_update(self):
        self.ensure_one()
        return {
            "job_id": self.new_job_id and self.new_job_id.id or False,
            "working_hours": self.new_working_hour_id
      Severity: Minor
      Found in hr_career_transition/models/hr_career_transition.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _prepare_contract_revert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def _prepare_contract_revert(self):
        self.ensure_one()
        return {
            "job_id": self.previous_job_id and self.previous_job_id.id or False,
            "working_hours": self.previous_working_hour_id
      Severity: Minor
      Found in hr_career_transition/models/hr_career_transition.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _prepare_new_contract has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def _prepare_new_contract(self):
        self.ensure_one()
        return {
            "employee_id": self.employee_id.id,
            "job_id": self.new_job_id and self.new_job_id.id or False,
      Severity: Minor
      Found in hr_career_transition/models/hr_career_transition.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function action_cancel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def action_cancel(self):
        for transition in self:
            if not transition._check_cant_cancel_latest_transition():
                msg = _("You can only cancel valid latest transition")
                raise UserError(msg)
      Severity: Minor
      Found in hr_career_transition/models/hr_career_transition.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _constrain_check_effective_date has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _constrain_check_effective_date(self):
        if self.state == "valid" and not self.archieve:
            criteria = [
                ("id", "!=", self.id),
                ("state", "=", "valid"),
      Severity: Minor
      Found in hr_career_transition/models/hr_career_transition.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function unlink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def unlink(self):
        strWarning = _("You can only delete data on draft state")
        for transition in self:
            if transition.state != "draft":
                if not self.env.context.get("force_unlink", False):
      Severity: Minor
      Found in hr_career_transition/models/hr_career_transition.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_contract_update(self):
        self.ensure_one()
        return {
            "job_id": self.new_job_id and self.new_job_id.id or False,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 7 hrs to fix
      hr_career_transition/models/hr_career_transition.py on lines 655..672

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_contract_revert(self):
        self.ensure_one()
        return {
            "job_id": self.previous_job_id and self.previous_job_id.id or False,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 7 hrs to fix
      hr_career_transition/models/hr_career_transition.py on lines 639..652

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @api.multi
    def onchange_previous_contract(self, previous_contract_id):
        value = self._get_value_before_onchange_previous_contract()
        domain = self._get_domain_before_onchange_previous_contract()
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 2 other locations - About 5 hrs to fix
      hr_job_family_modelling/models/hr_job.py on lines 38..50
      hr_job_family_modelling/models/hr_job_family_level.py on lines 109..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          @api.multi
    def unlink(self):
        strWarning = _("You can only delete data on draft state")
        for transition in self:
            if transition.state != "draft":
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 4 other locations - About 4 hrs to fix
      hr_award/models/hr_award.py on lines 261..269
      hr_dicipline/models/hr_dicipline.py on lines 259..267
      hr_recruitment_request/models/hr_recruitment_request.py on lines 340..348
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 193..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @api.model
    def create(self, values):
        _super = super(HrCareerTransition, self)
        result = _super.create(values)
        result.write(
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 2 hrs to fix
      hr_recruitment_request/models/hr_recruitment_request.py on lines 329..338

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          state = fields.Selection(
        string="State",
        required=True,
        readonly=True,
        track_visibility="onchange",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 2 hrs to fix
      hr_recruitment_request/models/hr_recruitment_request.py on lines 136..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

          @api.model
    def _default_employee_id(self):
        employees = self.env.user.employee_ids
        if len(employees) > 0:
            employee = employees[0]
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 3 other locations - About 2 hrs to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 32..37
      hr_award/models/hr_award.py on lines 32..37
      hr_dicipline/models/hr_dicipline.py on lines 30..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          type_id = fields.Many2one(
        string="Type",
        comodel_name="hr.career_transition_type",
        default=lambda self: self._default_type_id(),
        ondelete="restrict",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 2 hrs to fix
      hr_career_transition/models/hr_career_transition.py on lines 85..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          employee_id = fields.Many2one(
        string="Employee",
        comodel_name="hr.employee",
        default=lambda self: self._default_employee_id(),
        ondelete="restrict",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 2 hrs to fix
      hr_career_transition/models/hr_career_transition.py on lines 98..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          company_id = fields.Many2one(
        string="Company",
        comodel_name="res.company",
        default=lambda self: self._default_company_id(),
        ondelete="restrict",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 1 other location - About 1 hr to fix
      hr_recruitment_request/models/hr_recruitment_request.py on lines 53..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          @api.multi
    def validate_tier(self):
        _super = super(HrCareerTransition, self)
        _super.validate_tier()
        for document in self:
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 4 other locations - About 1 hr to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 303..309
      hr_award/models/hr_award.py on lines 234..240
      hr_dicipline/models/hr_dicipline.py on lines 232..238
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 203..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_confirm_data(self):
        self.ensure_one()
        result = {
            "state": "confirm",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 11 other locations - About 1 hr to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 340..348
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 350..358
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 360..368
      hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 231..239
      hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 241..249
      hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 251..259
      hr_career_transition/models/hr_career_transition.py on lines 483..491
      hr_recruitment_request/models/hr_recruitment_request.py on lines 255..263
      hr_recruitment_request/models/hr_recruitment_request.py on lines 265..273
      hr_recruitment_request/models/hr_recruitment_request.py on lines 275..283
      hr_recruitment_request/models/hr_recruitment_request.py on lines 285..293

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_approve_data(self):
        self.ensure_one()
        result = {
            "state": "open",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 11 other locations - About 1 hr to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 340..348
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 350..358
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 360..368
      hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 231..239
      hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 241..249
      hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 251..259
      hr_career_transition/models/hr_career_transition.py on lines 473..481
      hr_recruitment_request/models/hr_recruitment_request.py on lines 255..263
      hr_recruitment_request/models/hr_recruitment_request.py on lines 265..273
      hr_recruitment_request/models/hr_recruitment_request.py on lines 275..283
      hr_recruitment_request/models/hr_recruitment_request.py on lines 285..293

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_restart_data(self):
        self.ensure_one()
        result = {
            "state": "draft",
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 2 other locations - About 1 hr to fix
      hr_recruitment_request/models/hr_recruitment_request.py on lines 295..307
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 279..291

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def restart_validation(self):
        _super = super(HrCareerTransition, self)
        _super.restart_validation()
        for document in self:
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 11 other locations - About 1 hr to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 311..316
      hr_award/models/hr_award.py on lines 242..247
      hr_dicipline/models/hr_dicipline.py on lines 240..245
      hr_employee_training_allowance/models/hr_training.py on lines 23..28
      hr_employee_training_experience/models/hr_training_participant.py on lines 13..19
      hr_employee_training_experience/models/hr_training_participant.py on lines 27..32
      hr_payslip_multiple_approval/models/hr_payslip.py on lines 30..35
      hr_payslip_multiple_approval/models/hr_payslip.py on lines 37..42
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 211..216
      hr_timesheet_sheet_multiple_approval/models/hr_timesheet_sheet_sheet.py on lines 31..36
      hr_timesheet_sheet_multiple_approval/models/hr_timesheet_sheet_sheet.py on lines 38..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def action_confirm(self):
        for transition in self:
            transition.write(transition._prepare_confirm_data())
            transition.request_validation()
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 11 other locations - About 50 mins to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 318..322
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 329..333
      hr_award/models/hr_award.py on lines 271..275
      hr_award/models/hr_award.py on lines 292..296
      hr_dicipline/models/hr_dicipline.py on lines 269..273
      hr_dicipline/models/hr_dicipline.py on lines 290..294
      hr_employee_training/models/hr_training_partisipant.py on lines 103..107
      hr_employee_training/models/hr_training_session.py on lines 132..136
      hr_recruitment_request/models/hr_recruitment_request.py on lines 239..243
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 218..222
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 230..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          new_manager_id = fields.Many2one(
        string="New Manager",
        comodel_name="hr.employee",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          reason_id = fields.Many2one(
        string="Reason",
        comodel_name="hr.career_transition_type_reason",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          new_working_hour_id = fields.Many2one(
        string="New Working Schedule",
        comodel_name="resource.calendar",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          new_job_id = fields.Many2one(
        string="New Job Title",
        comodel_name="hr.job",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          previous_contract_id = fields.Many2one(
        string="Previous Contract",
        comodel_name="hr.contract",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          contract_type_id = fields.Many2one(
        string="Contract Type",
        comodel_name="hr.contract.type",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          new_department_id = fields.Many2one(
        string="New Department",
        comodel_name="hr.department",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 208..215
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          ref = fields.Char(
        string="# Reference",
        required=True,
        default="/",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 3 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 51..58
      hr_recruitment_request/models/hr_recruitment_request.py on lines 31..38
      hr_recruitment_request/models/hr_recruitment_request.py on lines 42..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          name = fields.Char(
        string="# Document",
        required=True,
        default="/",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 3 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 62..69
      hr_recruitment_request/models/hr_recruitment_request.py on lines 31..38
      hr_recruitment_request/models/hr_recruitment_request.py on lines 42..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 18 locations. Consider refactoring.
      Open

          new_company_id = fields.Many2one(
        string="New Company",
        comodel_name="res.company",
        ondelete="restrict",
        readonly=True,
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
      hr_career_transition/models/hr_career_transition.py on lines 137..144
      hr_career_transition/models/hr_career_transition.py on lines 149..156
      hr_career_transition/models/hr_career_transition.py on lines 196..203
      hr_career_transition/models/hr_career_transition.py on lines 219..226
      hr_career_transition/models/hr_career_transition.py on lines 230..237
      hr_career_transition/models/hr_career_transition.py on lines 241..248
      hr_career_transition/models/hr_career_transition.py on lines 252..259
      hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
      hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
      hr_employee_training/models/hr_training.py on lines 283..290
      hr_employee_training/models/hr_training.py on lines 294..301
      hr_employee_training_allowance/models/hr_training.py on lines 11..18
      hr_employee_training_evaluation/models/hr_training.py on lines 35..42
      hr_payslip_security/models/hr_payslip.py on lines 20..27
      hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
      hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
      hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          @api.multi
    @api.depends(
        "type_id",
    )
    def _compute_policy(self):
      Severity: Major
      Found in hr_career_transition/models/hr_career_transition.py and 5 other locations - About 40 mins to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 109..115
      hr_award/models/hr_award.py on lines 39..45
      hr_dicipline/models/hr_dicipline.py on lines 37..43
      hr_expense_workflow_policy/models/hr_expense.py on lines 12..18
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 31..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status