Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_contract_additional_field/models/hr_contract.py

Summary

Maintainability
B
5 hrs
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    @api.model
    def _default_employee_id(self):
        if len(self.env.user.employee_ids) > 0:
            return self.env.user.employee_ids[0].id
Severity: Major
Found in hr_contract_additional_field/models/hr_contract.py and 1 other location - About 1 hr to fix
hr_payslip_security/models/hr_payslip.py on lines 11..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    @api.onchange("employee_id")
    def onchange_contract_department_id(self):
        self.contract_department_id = False
        if self.employee_id:
            self.contract_department_id = self.employee_id.department_id
Severity: Major
Found in hr_contract_additional_field/models/hr_contract.py and 16 other locations - About 1 hr to fix
hr_award/models/hr_award.py on lines 378..382
hr_contract_additional_field/models/hr_contract.py on lines 56..60
hr_contract_additional_field/models/hr_contract.py on lines 62..66
hr_contract_additional_field/models/hr_contract.py on lines 68..72
hr_dicipline/models/hr_dicipline.py on lines 376..380
hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
hr_employee_training/models/hr_training_partisipant.py on lines 78..84
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
hr_expense_onchange/models/hr_expense.py on lines 11..15
hr_expense_onchange/models/hr_expense.py on lines 17..21
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    @api.onchange("employee_id")
    def onchange_manager_id(self):
        self.manager_id = False
        if self.employee_id:
            self.manager_id = self.employee_id.parent_id
Severity: Major
Found in hr_contract_additional_field/models/hr_contract.py and 16 other locations - About 1 hr to fix
hr_award/models/hr_award.py on lines 378..382
hr_contract_additional_field/models/hr_contract.py on lines 50..54
hr_contract_additional_field/models/hr_contract.py on lines 56..60
hr_contract_additional_field/models/hr_contract.py on lines 62..66
hr_dicipline/models/hr_dicipline.py on lines 376..380
hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
hr_employee_training/models/hr_training_partisipant.py on lines 78..84
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
hr_expense_onchange/models/hr_expense.py on lines 11..15
hr_expense_onchange/models/hr_expense.py on lines 17..21
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    @api.onchange("employee_id")
    def onchange_job_id(self):
        self.job_id = False
        if self.employee_id:
            self.job_id = self.employee_id.job_id
Severity: Major
Found in hr_contract_additional_field/models/hr_contract.py and 16 other locations - About 1 hr to fix
hr_award/models/hr_award.py on lines 378..382
hr_contract_additional_field/models/hr_contract.py on lines 50..54
hr_contract_additional_field/models/hr_contract.py on lines 56..60
hr_contract_additional_field/models/hr_contract.py on lines 68..72
hr_dicipline/models/hr_dicipline.py on lines 376..380
hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
hr_employee_training/models/hr_training_partisipant.py on lines 78..84
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
hr_expense_onchange/models/hr_expense.py on lines 11..15
hr_expense_onchange/models/hr_expense.py on lines 17..21
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    @api.onchange("employee_id")
    def onchange_company_id(self):
        self.company_id = False
        if self.employee_id:
            self.company_id = self.employee_id.company_id
Severity: Major
Found in hr_contract_additional_field/models/hr_contract.py and 16 other locations - About 1 hr to fix
hr_award/models/hr_award.py on lines 378..382
hr_contract_additional_field/models/hr_contract.py on lines 50..54
hr_contract_additional_field/models/hr_contract.py on lines 62..66
hr_contract_additional_field/models/hr_contract.py on lines 68..72
hr_dicipline/models/hr_dicipline.py on lines 376..380
hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
hr_employee_training/models/hr_training_partisipant.py on lines 78..84
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
hr_expense_onchange/models/hr_expense.py on lines 11..15
hr_expense_onchange/models/hr_expense.py on lines 17..21
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status