Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_dicipline/models/hr_dicipline.py

Summary

Maintainability
F
4 days
Test Coverage

File hr_dicipline.py has 347 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright 2019 OpenSynergy Indonesia
# Copyright 2020 PT. Simetri Sinergi Indonesia
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
from openerp import _, api, fields, models
Severity: Minor
Found in hr_dicipline/models/hr_dicipline.py - About 4 hrs to fix

    HrDicipline has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class HrDicipline(models.Model):
    _name = "hr.dicipline"
    _description = "Employee Dicipline"
    _inherit = [
        "mail.thread",
    Severity: Minor
    Found in hr_dicipline/models/hr_dicipline.py - About 2 hrs to fix

      Function unlink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def unlink(self):
        strWarning = _("You can only delete data on draft state")
        for document in self:
            if document.state != "draft":
                if not self.env.context.get("force_unlink", False):
      Severity: Minor
      Found in hr_dicipline/models/hr_dicipline.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          @api.multi
    def unlink(self):
        strWarning = _("You can only delete data on draft state")
        for document in self:
            if document.state != "draft":
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 4 other locations - About 4 hrs to fix
      hr_award/models/hr_award.py on lines 261..269
      hr_career_transition/models/hr_career_transition.py on lines 710..718
      hr_recruitment_request/models/hr_recruitment_request.py on lines 340..348
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 193..201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_restart_data(self):
        self.ensure_one()
        result = {
            "state": "draft",
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 1 other location - About 2 hrs to fix
      hr_award/models/hr_award.py on lines 353..372

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          state = fields.Selection(
        string="State",
        copy=False,
        selection=[
            ("draft", "Draft"),
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 1 other location - About 2 hrs to fix
      hr_award/models/hr_award.py on lines 132..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

          @api.model
    def _default_employee_id(self):
        employees = self.env.user.employee_ids
        if len(employees) > 0:
            employee = employees[0]
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 3 other locations - About 2 hrs to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 32..37
      hr_award/models/hr_award.py on lines 32..37
      hr_career_transition/models/hr_career_transition.py on lines 44..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          employee_id = fields.Many2one(
        string="Employee",
        comodel_name="hr.employee",
        default=lambda self: self._default_employee_id(),
        required=True,
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 1 other location - About 1 hr to fix
      hr_award/models/hr_award.py on lines 94..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          @api.multi
    def validate_tier(self):
        _super = super(HrDicipline, self)
        _super.validate_tier()
        for document in self:
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 4 other locations - About 1 hr to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 303..309
      hr_award/models/hr_award.py on lines 234..240
      hr_career_transition/models/hr_career_transition.py on lines 458..464
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 203..209

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_cancel_data(self):
        self.ensure_one()
        result = {
            "state": "cancel",
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 12 other locations - About 1 hr to fix
      hr_award/models/hr_award.py on lines 303..311
      hr_award/models/hr_award.py on lines 313..321
      hr_award/models/hr_award.py on lines 323..331
      hr_award/models/hr_award.py on lines 333..341
      hr_award/models/hr_award.py on lines 343..351
      hr_dicipline/models/hr_dicipline.py on lines 301..309
      hr_dicipline/models/hr_dicipline.py on lines 311..319
      hr_dicipline/models/hr_dicipline.py on lines 321..329
      hr_dicipline/models/hr_dicipline.py on lines 341..349
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 241..249
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 251..259
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 269..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_approve_data(self):
        self.ensure_one()
        result = {
            "state": "approve",
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 12 other locations - About 1 hr to fix
      hr_award/models/hr_award.py on lines 303..311
      hr_award/models/hr_award.py on lines 313..321
      hr_award/models/hr_award.py on lines 323..331
      hr_award/models/hr_award.py on lines 333..341
      hr_award/models/hr_award.py on lines 343..351
      hr_dicipline/models/hr_dicipline.py on lines 301..309
      hr_dicipline/models/hr_dicipline.py on lines 321..329
      hr_dicipline/models/hr_dicipline.py on lines 331..339
      hr_dicipline/models/hr_dicipline.py on lines 341..349
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 241..249
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 251..259
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 269..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_done_data(self):
        self.ensure_one()
        result = {
            "state": "done",
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 12 other locations - About 1 hr to fix
      hr_award/models/hr_award.py on lines 303..311
      hr_award/models/hr_award.py on lines 313..321
      hr_award/models/hr_award.py on lines 323..331
      hr_award/models/hr_award.py on lines 333..341
      hr_award/models/hr_award.py on lines 343..351
      hr_dicipline/models/hr_dicipline.py on lines 301..309
      hr_dicipline/models/hr_dicipline.py on lines 311..319
      hr_dicipline/models/hr_dicipline.py on lines 321..329
      hr_dicipline/models/hr_dicipline.py on lines 331..339
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 241..249
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 251..259
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 269..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_open_data(self):
        self.ensure_one()
        result = {
            "state": "open",
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 12 other locations - About 1 hr to fix
      hr_award/models/hr_award.py on lines 303..311
      hr_award/models/hr_award.py on lines 313..321
      hr_award/models/hr_award.py on lines 323..331
      hr_award/models/hr_award.py on lines 333..341
      hr_award/models/hr_award.py on lines 343..351
      hr_dicipline/models/hr_dicipline.py on lines 301..309
      hr_dicipline/models/hr_dicipline.py on lines 311..319
      hr_dicipline/models/hr_dicipline.py on lines 331..339
      hr_dicipline/models/hr_dicipline.py on lines 341..349
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 241..249
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 251..259
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 269..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

          @api.multi
    def _prepare_confirm_data(self):
        self.ensure_one()
        result = {
            "state": "confirm",
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 12 other locations - About 1 hr to fix
      hr_award/models/hr_award.py on lines 303..311
      hr_award/models/hr_award.py on lines 313..321
      hr_award/models/hr_award.py on lines 323..331
      hr_award/models/hr_award.py on lines 333..341
      hr_award/models/hr_award.py on lines 343..351
      hr_dicipline/models/hr_dicipline.py on lines 311..319
      hr_dicipline/models/hr_dicipline.py on lines 321..329
      hr_dicipline/models/hr_dicipline.py on lines 331..339
      hr_dicipline/models/hr_dicipline.py on lines 341..349
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 241..249
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 251..259
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 269..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def restart_validation(self):
        _super = super(HrDicipline, self)
        _super.restart_validation()
        for document in self:
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 11 other locations - About 1 hr to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 311..316
      hr_award/models/hr_award.py on lines 242..247
      hr_career_transition/models/hr_career_transition.py on lines 466..471
      hr_employee_training_allowance/models/hr_training.py on lines 23..28
      hr_employee_training_experience/models/hr_training_participant.py on lines 13..19
      hr_employee_training_experience/models/hr_training_participant.py on lines 27..32
      hr_payslip_multiple_approval/models/hr_payslip.py on lines 30..35
      hr_payslip_multiple_approval/models/hr_payslip.py on lines 37..42
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 211..216
      hr_timesheet_sheet_multiple_approval/models/hr_timesheet_sheet_sheet.py on lines 31..36
      hr_timesheet_sheet_multiple_approval/models/hr_timesheet_sheet_sheet.py on lines 38..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 17 locations. Consider refactoring.
      Open

          @api.onchange("employee_id")
    def _onchange_department_id(self):
        self.department_id = False
        if self.employee_id:
            self.department_id = self.employee_id.department_id
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 16 other locations - About 1 hr to fix
      hr_award/models/hr_award.py on lines 378..382
      hr_contract_additional_field/models/hr_contract.py on lines 50..54
      hr_contract_additional_field/models/hr_contract.py on lines 56..60
      hr_contract_additional_field/models/hr_contract.py on lines 62..66
      hr_contract_additional_field/models/hr_contract.py on lines 68..72
      hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
      hr_employee_training/models/hr_training_partisipant.py on lines 78..84
      hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
      hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
      hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
      hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
      hr_expense_onchange/models/hr_expense.py on lines 11..15
      hr_expense_onchange/models/hr_expense.py on lines 17..21
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
      hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          name = fields.Char(
        string="# Document",
        required=True,
        default="/",
        copy=False,
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 3 other locations - About 55 mins to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 117..125
      hr_award/models/hr_award.py on lines 55..63
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 39..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def button_confirm(self):
        for document in self:
            document.write(document._prepare_confirm_data())
            document.request_validation()
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 11 other locations - About 50 mins to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 318..322
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 329..333
      hr_award/models/hr_award.py on lines 271..275
      hr_award/models/hr_award.py on lines 292..296
      hr_career_transition/models/hr_career_transition.py on lines 421..425
      hr_dicipline/models/hr_dicipline.py on lines 290..294
      hr_employee_training/models/hr_training_partisipant.py on lines 103..107
      hr_employee_training/models/hr_training_session.py on lines 132..136
      hr_recruitment_request/models/hr_recruitment_request.py on lines 239..243
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 218..222
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 230..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 12 locations. Consider refactoring.
      Open

          @api.multi
    def button_cancel(self):
        for document in self:
            document.write(document._prepare_cancel_data())
            document.restart_validation()
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 11 other locations - About 50 mins to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 318..322
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 329..333
      hr_award/models/hr_award.py on lines 271..275
      hr_award/models/hr_award.py on lines 292..296
      hr_career_transition/models/hr_career_transition.py on lines 421..425
      hr_dicipline/models/hr_dicipline.py on lines 269..273
      hr_employee_training/models/hr_training_partisipant.py on lines 103..107
      hr_employee_training/models/hr_training_session.py on lines 132..136
      hr_recruitment_request/models/hr_recruitment_request.py on lines 239..243
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 218..222
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 230..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          @api.multi
    @api.depends(
        "type_id",
    )
    def _compute_allowed_reason_ids(self):
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 2 other locations - About 50 mins to fix
      hr_award/models/hr_award.py on lines 47..53
      hr_job_family_modelling/models/hr_job_family_level.py on lines 13..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          @api.multi
    @api.depends(
        "type_id",
    )
    def _compute_policy(self):
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 5 other locations - About 40 mins to fix
      hr_attendance_overtime_request/models/hr_overtime_request.py on lines 109..115
      hr_award/models/hr_award.py on lines 39..45
      hr_career_transition/models/hr_career_transition.py on lines 28..34
      hr_expense_workflow_policy/models/hr_expense.py on lines 12..18
      hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 31..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

          type_id = fields.Many2one(
        string="Type",
        comodel_name="hr.dicipline_type",
        required=True,
        readonly=True,
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 6 other locations - About 40 mins to fix
      hr_award/models/hr_award.py on lines 67..74
      hr_award/models/hr_award.py on lines 78..85
      hr_dicipline/models/hr_dicipline.py on lines 76..83
      hr_employee_training/models/hr_training.py on lines 188..195
      hr_employee_training/models/hr_training.py on lines 199..206
      hr_employee_training/models/hr_training.py on lines 220..227

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

          reason_id = fields.Many2one(
        string="Reason",
        comodel_name="hr.dicipline_reason",
        required=True,
        readonly=True,
      Severity: Major
      Found in hr_dicipline/models/hr_dicipline.py and 6 other locations - About 40 mins to fix
      hr_award/models/hr_award.py on lines 67..74
      hr_award/models/hr_award.py on lines 78..85
      hr_dicipline/models/hr_dicipline.py on lines 65..72
      hr_employee_training/models/hr_training.py on lines 188..195
      hr_employee_training/models/hr_training.py on lines 199..206
      hr_employee_training/models/hr_training.py on lines 220..227

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status