Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_dicipline_fine/models/hr_dicipline.py

Summary

Maintainability
D
1 day
Test Coverage

Function _prepare_fine_move_line has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _prepare_fine_move_line(self, name, debit, credit, account_id, partner_id):
Severity: Minor
Found in hr_dicipline_fine/models/hr_dicipline.py - About 35 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @api.multi
    def _get_fine_move_journal(self):
        self.ensure_one()
        result = self.journal_id
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 2 other locations - About 3 hrs to fix
    hr_dicipline_fine/models/hr_dicipline.py on lines 108..119
    hr_dicipline_fine/models/hr_dicipline.py on lines 121..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @api.multi
    def _get_fine_move_receivable_account(self):
        self.ensure_one()
        result = self.receivable_account_id
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 2 other locations - About 3 hrs to fix
    hr_dicipline_fine/models/hr_dicipline.py on lines 95..106
    hr_dicipline_fine/models/hr_dicipline.py on lines 108..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @api.multi
    def _get_fine_move_income_account(self):
        self.ensure_one()
        result = self.income_account_id
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 2 other locations - About 3 hrs to fix
    hr_dicipline_fine/models/hr_dicipline.py on lines 95..106
    hr_dicipline_fine/models/hr_dicipline.py on lines 121..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @api.multi
    def _get_fine_move_partner(self):
        self.ensure_one()
        result = self.employee_id.address_home_id
        if not result:
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 1 other location - About 2 hrs to fix
    hr_timesheet_accrue_income/models/hr_analytic_timesheet.py on lines 193..200

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @api.multi
    def _create_fine_move(self):
        self.ensure_one()
        obj_move = self.env["account.move"]
        return obj_move.create(self._prepare_fine_move())
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 1 other location - About 1 hr to fix
    hr_employee_training_evaluation/models/hr_training_participant_evaluation.py on lines 134..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange("company_id")
    def onchange_currency_id(self):
        self.currency_id = False
        if self.company_id:
            self.currency_id = self.company_id.currency_id
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 56..60
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_contract_additional_field/models/hr_contract.py on lines 68..72
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_employee_training/models/hr_training_partisipant.py on lines 78..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status