Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_employee_training/models/hr_training.py

Summary

Maintainability
D
3 days
Test Coverage

File hr_training.py has 394 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright 2018 OpenSynergy Indonesia
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from openerp import api, fields, models
Severity: Minor
Found in hr_employee_training/models/hr_training.py - About 5 hrs to fix

    Function _compute_policy has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

        def _compute_policy(self):
        user_group_ids = self.env.user.groups_id.ids
        for training in self:
            can_confirm = (
                can_approve
    Severity: Minor
    Found in hr_employee_training/models/hr_training.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _check_session_close has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def _check_session_close(self):
        strWarning = _("There are unfinished session(s)")
        if self.state == "finish":
            for session in self.session_ids:
                if session.state not in ["finish", "cancel"]:
    Severity: Minor
    Found in hr_employee_training/models/hr_training.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        @api.constrains("date_start", "date_end")
    def _check_duration(self):
        strWarning = _("Date end must be greater than date start")
        if self.date_start and self.date_end:
            if self.date_end < self.date_start:
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 2 other locations - About 2 hrs to fix
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 420..425
    hr_employee_training/models/hr_training_session.py on lines 207..212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        trainer_ids = fields.Many2many(
        string="Trainer",
        comodel_name="res.partner",
        relation="rel_training_2_trainer",
        column1="training_id",
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 3 other locations - About 1 hr to fix
    hr_employee_training/models/hr_training.py on lines 267..279
    hr_employee_training/models/hr_training_session.py on lines 38..50
    hr_employee_training/models/hr_training_session.py on lines 54..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        observer_ids = fields.Many2many(
        string="Observer",
        comodel_name="res.partner",
        relation="rel_training_2_observer",
        column1="training_id",
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 3 other locations - About 1 hr to fix
    hr_employee_training/models/hr_training.py on lines 251..263
    hr_employee_training/models/hr_training_session.py on lines 38..50
    hr_employee_training/models/hr_training_session.py on lines 54..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        method_ids = fields.Many2many(
        string="Training Method",
        comodel_name="hr.training_method",
        relation="rel_training_2_training_method",
        column1="training_id",
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 3 other locations - About 1 hr to fix
    hr_employee_training/models/hr_training.py on lines 120..129
    hr_employee_training/models/hr_training.py on lines 162..171
    hr_employee_training/models/hr_training.py on lines 175..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        vendor_ids = fields.Many2many(
        string="Vendor",
        comodel_name="res.partner",
        relation="rel_training_vendor",
        column1="training_id",
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 3 other locations - About 1 hr to fix
    hr_employee_training/models/hr_training.py on lines 107..116
    hr_employee_training/models/hr_training.py on lines 162..171
    hr_employee_training/models/hr_training.py on lines 175..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        training_syllabus_id = fields.Many2many(
        string="Training Syllabus",
        comodel_name="hr.training_syllabus",
        relation="rel_training_2_syllabus",
        column1="training_id",
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 3 other locations - About 1 hr to fix
    hr_employee_training/models/hr_training.py on lines 107..116
    hr_employee_training/models/hr_training.py on lines 120..129
    hr_employee_training/models/hr_training.py on lines 162..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        training_purpose_ids = fields.Many2many(
        string="Training Purpose",
        comodel_name="hr.training_purpose",
        relation="rel_training_2_purpose",
        column1="training_id",
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 3 other locations - About 1 hr to fix
    hr_employee_training/models/hr_training.py on lines 107..116
    hr_employee_training/models/hr_training.py on lines 120..129
    hr_employee_training/models/hr_training.py on lines 175..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        partisipant_ids = fields.One2many(
        string="Partisipants",
        comodel_name="hr.training_partisipant",
        inverse_name="training_id",
        readonly=True,
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 17 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 137..144
    hr_career_transition/models/hr_career_transition.py on lines 149..156
    hr_career_transition/models/hr_career_transition.py on lines 196..203
    hr_career_transition/models/hr_career_transition.py on lines 208..215
    hr_career_transition/models/hr_career_transition.py on lines 219..226
    hr_career_transition/models/hr_career_transition.py on lines 230..237
    hr_career_transition/models/hr_career_transition.py on lines 241..248
    hr_career_transition/models/hr_career_transition.py on lines 252..259
    hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
    hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
    hr_employee_training/models/hr_training.py on lines 294..301
    hr_employee_training_allowance/models/hr_training.py on lines 11..18
    hr_employee_training_evaluation/models/hr_training.py on lines 35..42
    hr_payslip_security/models/hr_payslip.py on lines 20..27
    hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
    hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
    hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        session_ids = fields.One2many(
        string="Sessions",
        comodel_name="hr.training_session",
        inverse_name="training_id",
        readonly=True,
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 17 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 137..144
    hr_career_transition/models/hr_career_transition.py on lines 149..156
    hr_career_transition/models/hr_career_transition.py on lines 196..203
    hr_career_transition/models/hr_career_transition.py on lines 208..215
    hr_career_transition/models/hr_career_transition.py on lines 219..226
    hr_career_transition/models/hr_career_transition.py on lines 230..237
    hr_career_transition/models/hr_career_transition.py on lines 241..248
    hr_career_transition/models/hr_career_transition.py on lines 252..259
    hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
    hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
    hr_employee_training/models/hr_training.py on lines 283..290
    hr_employee_training_allowance/models/hr_training.py on lines 11..18
    hr_employee_training_evaluation/models/hr_training.py on lines 35..42
    hr_payslip_security/models/hr_payslip.py on lines 20..27
    hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
    hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
    hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        participant_type_id = fields.Many2one(
        string="Default Participant Type",
        comodel_name="hr.training_participant_type",
        required=True,
        readonly=False,
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 6 other locations - About 40 mins to fix
    hr_award/models/hr_award.py on lines 67..74
    hr_award/models/hr_award.py on lines 78..85
    hr_dicipline/models/hr_dicipline.py on lines 65..72
    hr_dicipline/models/hr_dicipline.py on lines 76..83
    hr_employee_training/models/hr_training.py on lines 188..195
    hr_employee_training/models/hr_training.py on lines 199..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        request_by_id = fields.Many2one(
        string="Request By",
        comodel_name="hr.employee",
        required=True,
        readonly=True,
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 6 other locations - About 40 mins to fix
    hr_award/models/hr_award.py on lines 67..74
    hr_award/models/hr_award.py on lines 78..85
    hr_dicipline/models/hr_dicipline.py on lines 65..72
    hr_dicipline/models/hr_dicipline.py on lines 76..83
    hr_employee_training/models/hr_training.py on lines 199..206
    hr_employee_training/models/hr_training.py on lines 220..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        responsible_id = fields.Many2one(
        string="Primary PIC",
        comodel_name="hr.employee",
        required=True,
        readonly=True,
    Severity: Major
    Found in hr_employee_training/models/hr_training.py and 6 other locations - About 40 mins to fix
    hr_award/models/hr_award.py on lines 67..74
    hr_award/models/hr_award.py on lines 78..85
    hr_dicipline/models/hr_dicipline.py on lines 65..72
    hr_dicipline/models/hr_dicipline.py on lines 76..83
    hr_employee_training/models/hr_training.py on lines 188..195
    hr_employee_training/models/hr_training.py on lines 220..227

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status