Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_employee_training_allowance/models/hr_training.py

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    @api.multi
    def button_approve(self):
        _super = super(HrTraining, self)
        _super.button_approve()
        for document in self:
Severity: Major
Found in hr_employee_training_allowance/models/hr_training.py and 11 other locations - About 1 hr to fix
hr_attendance_overtime_request/models/hr_overtime_request.py on lines 311..316
hr_award/models/hr_award.py on lines 242..247
hr_career_transition/models/hr_career_transition.py on lines 466..471
hr_dicipline/models/hr_dicipline.py on lines 240..245
hr_employee_training_experience/models/hr_training_participant.py on lines 13..19
hr_employee_training_experience/models/hr_training_participant.py on lines 27..32
hr_payslip_multiple_approval/models/hr_payslip.py on lines 30..35
hr_payslip_multiple_approval/models/hr_payslip.py on lines 37..42
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 211..216
hr_timesheet_sheet_multiple_approval/models/hr_timesheet_sheet_sheet.py on lines 31..36
hr_timesheet_sheet_multiple_approval/models/hr_timesheet_sheet_sheet.py on lines 38..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

    allowance_ids = fields.One2many(
        string="Training Allowance",
        comodel_name="hr.training_allowance",
        inverse_name="training_id",
        readonly=True,
Severity: Major
Found in hr_employee_training_allowance/models/hr_training.py and 17 other locations - About 40 mins to fix
hr_career_transition/models/hr_career_transition.py on lines 137..144
hr_career_transition/models/hr_career_transition.py on lines 149..156
hr_career_transition/models/hr_career_transition.py on lines 196..203
hr_career_transition/models/hr_career_transition.py on lines 208..215
hr_career_transition/models/hr_career_transition.py on lines 219..226
hr_career_transition/models/hr_career_transition.py on lines 230..237
hr_career_transition/models/hr_career_transition.py on lines 241..248
hr_career_transition/models/hr_career_transition.py on lines 252..259
hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
hr_employee_training/models/hr_training.py on lines 283..290
hr_employee_training/models/hr_training.py on lines 294..301
hr_employee_training_evaluation/models/hr_training.py on lines 35..42
hr_payslip_security/models/hr_payslip.py on lines 20..27
hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status