Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_expense_header_account/models/hr_expense.py

Summary

Maintainability
A
1 hr
Test Coverage

Function action_move_create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def action_move_create(self):
        """Reconcile supplier invoice payables with the created move lines."""
        res = super(HrExpense, self).action_move_create()
        for expense in self:
            for line in expense.account_move_id.line_id:
Severity: Minor
Found in hr_expense_header_account/models/hr_expense.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _get_partner_account has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _get_partner_account(self):
        address_home_id = self.employee_id.address_home_id
        if address_home_id:
            commercial_partner_id = address_home_id.commercial_partner_id
            if commercial_partner_id:
Severity: Minor
Found in hr_expense_header_account/models/hr_expense.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status