Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_recruitment_request/models/hr_recruitment_request.py

Summary

Maintainability
F
3 days
Test Coverage

File hr_recruitment_request.py has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright 2019 OpenSynergy Indonesia
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from openerp import _, api, fields, models
Severity: Minor
Found in hr_recruitment_request/models/hr_recruitment_request.py - About 3 hrs to fix

    Function unlink has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def unlink(self):
        strWarning = _("You can only delete data on draft state")
        for rec_request in self:
            if rec_request.state != "draft":
                if not self.env.context.get("force_unlink", False):
    Severity: Minor
    Found in hr_recruitment_request/models/hr_recruitment_request.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        @api.multi
    def unlink(self):
        strWarning = _("You can only delete data on draft state")
        for rec_request in self:
            if rec_request.state != "draft":
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 4 other locations - About 4 hrs to fix
    hr_award/models/hr_award.py on lines 261..269
    hr_career_transition/models/hr_career_transition.py on lines 710..718
    hr_dicipline/models/hr_dicipline.py on lines 259..267
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 193..201

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        state = fields.Selection(
        string="State",
        required=True,
        readonly=True,
        track_visibility="onchange",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 1 other location - About 2 hrs to fix
    hr_career_transition/models/hr_career_transition.py on lines 331..341

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @api.model
    def create(self, values):
        _super = super(HrRecruitmentRequest, self)
        result = _super.create(values)
        result.write(
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 1 other location - About 2 hrs to fix
    hr_career_transition/models/hr_career_transition.py on lines 530..539

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        company_id = fields.Many2one(
        string="Company",
        comodel_name="res.company",
        default=lambda self: self._default_company_id(),
        ondelete="restrict",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 1 other location - About 1 hr to fix
    hr_career_transition/models/hr_career_transition.py on lines 73..81

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        @api.multi
    def _prepare_valid_data(self):
        self.ensure_one()
        result = {
            "state": "valid",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 11 other locations - About 1 hr to fix
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 340..348
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 350..358
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 360..368
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 231..239
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 241..249
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 251..259
    hr_career_transition/models/hr_career_transition.py on lines 473..481
    hr_career_transition/models/hr_career_transition.py on lines 483..491
    hr_recruitment_request/models/hr_recruitment_request.py on lines 255..263
    hr_recruitment_request/models/hr_recruitment_request.py on lines 265..273
    hr_recruitment_request/models/hr_recruitment_request.py on lines 285..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        @api.multi
    def _prepare_confirm_data(self):
        self.ensure_one()
        result = {
            "state": "confirm",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 11 other locations - About 1 hr to fix
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 340..348
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 350..358
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 360..368
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 231..239
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 241..249
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 251..259
    hr_career_transition/models/hr_career_transition.py on lines 473..481
    hr_career_transition/models/hr_career_transition.py on lines 483..491
    hr_recruitment_request/models/hr_recruitment_request.py on lines 265..273
    hr_recruitment_request/models/hr_recruitment_request.py on lines 275..283
    hr_recruitment_request/models/hr_recruitment_request.py on lines 285..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        @api.multi
    def _prepare_approve_data(self):
        self.ensure_one()
        result = {
            "state": "open",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 11 other locations - About 1 hr to fix
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 340..348
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 350..358
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 360..368
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 231..239
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 241..249
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 251..259
    hr_career_transition/models/hr_career_transition.py on lines 473..481
    hr_career_transition/models/hr_career_transition.py on lines 483..491
    hr_recruitment_request/models/hr_recruitment_request.py on lines 255..263
    hr_recruitment_request/models/hr_recruitment_request.py on lines 275..283
    hr_recruitment_request/models/hr_recruitment_request.py on lines 285..293

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        @api.multi
    def _prepare_cancel_data(self):
        self.ensure_one()
        result = {
            "state": "cancel",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 11 other locations - About 1 hr to fix
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 340..348
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 350..358
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 360..368
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 231..239
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 241..249
    hr_attendance_overtime_request_batch/models/hr_overtime_request_batch.py on lines 251..259
    hr_career_transition/models/hr_career_transition.py on lines 473..481
    hr_career_transition/models/hr_career_transition.py on lines 483..491
    hr_recruitment_request/models/hr_recruitment_request.py on lines 255..263
    hr_recruitment_request/models/hr_recruitment_request.py on lines 265..273
    hr_recruitment_request/models/hr_recruitment_request.py on lines 275..283

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @api.multi
    def action_approve(self):
        for rec_request in self:
            rec_request.write(rec_request._prepare_approve_data())
            rec_request.job_id.write(rec_request._prepare_job_opening())
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 1 other location - About 1 hr to fix
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 224..228

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        @api.multi
    def _prepare_restart_data(self):
        self.ensure_one()
        result = {
            "state": "draft",
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 2 other locations - About 1 hr to fix
    hr_career_transition/models/hr_career_transition.py on lines 516..528
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 279..291

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        department_id = fields.Many2one(
        string="Department",
        comodel_name="hr.department",
        required=True,
        ondelete="restrict",
    Severity: Minor
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 1 other location - About 55 mins to fix
    hr_recruitment_request/models/hr_recruitment_request.py on lines 90..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        job_id = fields.Many2one(
        string="Job Position",
        comodel_name="hr.job",
        required=True,
        ondelete="restrict",
    Severity: Minor
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 1 other location - About 55 mins to fix
    hr_recruitment_request/models/hr_recruitment_request.py on lines 65..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 12 locations. Consider refactoring.
    Open

        @api.multi
    def action_valid(self):
        for rec_request in self:
            rec_request.write(rec_request._prepare_valid_data())
            rec_request._close_job_recruitment()
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 11 other locations - About 50 mins to fix
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 318..322
    hr_attendance_overtime_request/models/hr_overtime_request.py on lines 329..333
    hr_award/models/hr_award.py on lines 271..275
    hr_award/models/hr_award.py on lines 292..296
    hr_career_transition/models/hr_career_transition.py on lines 421..425
    hr_dicipline/models/hr_dicipline.py on lines 269..273
    hr_dicipline/models/hr_dicipline.py on lines 290..294
    hr_employee_training/models/hr_training_partisipant.py on lines 103..107
    hr_employee_training/models/hr_training_session.py on lines 132..136
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 218..222
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 230..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        replacement_id = fields.Many2one(
        string="Replacement for",
        comodel_name="hr.employee",
        ondelete="restrict",
        readonly=True,
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 17 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 137..144
    hr_career_transition/models/hr_career_transition.py on lines 149..156
    hr_career_transition/models/hr_career_transition.py on lines 196..203
    hr_career_transition/models/hr_career_transition.py on lines 208..215
    hr_career_transition/models/hr_career_transition.py on lines 219..226
    hr_career_transition/models/hr_career_transition.py on lines 230..237
    hr_career_transition/models/hr_career_transition.py on lines 241..248
    hr_career_transition/models/hr_career_transition.py on lines 252..259
    hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
    hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
    hr_employee_training/models/hr_training.py on lines 283..290
    hr_employee_training/models/hr_training.py on lines 294..301
    hr_employee_training_allowance/models/hr_training.py on lines 11..18
    hr_employee_training_evaluation/models/hr_training.py on lines 35..42
    hr_payslip_security/models/hr_payslip.py on lines 20..27
    hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
    hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        ref = fields.Char(
        string="# Reference",
        required=True,
        default="/",
        readonly=True,
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 3 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 51..58
    hr_career_transition/models/hr_career_transition.py on lines 62..69
    hr_recruitment_request/models/hr_recruitment_request.py on lines 31..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        name = fields.Char(
        string="# Document",
        required=True,
        default="/",
        readonly=True,
    Severity: Major
    Found in hr_recruitment_request/models/hr_recruitment_request.py and 3 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 51..58
    hr_career_transition/models/hr_career_transition.py on lines 62..69
    hr_recruitment_request/models/hr_recruitment_request.py on lines 42..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status