Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_timesheet_onchange/models/hr_analytic_timesheet.py

Summary

Maintainability
C
1 day
Test Coverage

Function onchange_general_account_id has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def onchange_general_account_id(self):
        account = False
        is_sale_line = False

        if self.journal_id:
Severity: Minor
Found in hr_timesheet_onchange/models/hr_analytic_timesheet.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onchange_amount has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def onchange_amount(self):
        is_sale_line = False
        obj_price_type = self.env["product.price.type"]
        obj_precision = self.env["decimal.precision"]
        result = 0.0
Severity: Minor
Found in hr_timesheet_onchange/models/hr_analytic_timesheet.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @api.onchange(
        "user_id",
    )
    def onchange_journal_id(self):
        self.journal_id = False
Severity: Major
Found in hr_timesheet_onchange/models/hr_analytic_timesheet.py and 1 other location - About 3 hrs to fix
hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 36..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @api.onchange(
        "user_id",
    )
    def onchange_product_id(self):
        self.product_id = False
Severity: Major
Found in hr_timesheet_onchange/models/hr_analytic_timesheet.py and 1 other location - About 3 hrs to fix
hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 46..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

    @api.onchange(
        "product_id",
    )
    def onchange_uom_id(self):
        self.product_uom_id = False
Severity: Major
Found in hr_timesheet_onchange/models/hr_analytic_timesheet.py and 16 other locations - About 1 hr to fix
hr_award/models/hr_award.py on lines 378..382
hr_contract_additional_field/models/hr_contract.py on lines 50..54
hr_contract_additional_field/models/hr_contract.py on lines 56..60
hr_contract_additional_field/models/hr_contract.py on lines 62..66
hr_contract_additional_field/models/hr_contract.py on lines 68..72
hr_dicipline/models/hr_dicipline.py on lines 376..380
hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
hr_employee_training/models/hr_training_partisipant.py on lines 78..84
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
hr_expense_onchange/models/hr_expense.py on lines 11..15
hr_expense_onchange/models/hr_expense.py on lines 17..21
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status