Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star
hr_worked_days_from_activity/tests/base.py

Summary

Maintainability
F
3 days
Test Coverage

Function setUp has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def setUp(self):
        super(BaseTestHrPayslip, self).setUp()
        # Object
        self.obj_timesheet = self.env["hr_timesheet_sheet.sheet"]
        self.obj_wd = self.env["hr.payslip.worked_days"]
Severity: Minor
Found in hr_worked_days_from_activity/tests/base.py - About 1 hr to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            self.ts_line2 = self.obj_ts_line.create(
            {
                "name": "Training",
                "user_id": self.employee.user_id.id,
                "date": (
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 4 other locations - About 5 hrs to fix
    hr_worked_days_from_activity/tests/base.py on lines 93..106
    hr_worked_days_from_activity/tests/base.py on lines 127..140
    hr_worked_days_from_activity/tests/base.py on lines 152..165
    hr_worked_days_from_activity/tests/base.py on lines 186..199

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            self.ts_line1 = self.obj_ts_line.create(
            {
                "name": "Consultancy",
                "user_id": self.employee.user_id.id,
                "date": (
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 4 other locations - About 5 hrs to fix
    hr_worked_days_from_activity/tests/base.py on lines 110..123
    hr_worked_days_from_activity/tests/base.py on lines 127..140
    hr_worked_days_from_activity/tests/base.py on lines 152..165
    hr_worked_days_from_activity/tests/base.py on lines 186..199

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            self.ts_line4 = self.obj_ts_line.create(
            {
                "name": "Training",
                "user_id": self.employee.user_id.id,
                "date": (
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 4 other locations - About 5 hrs to fix
    hr_worked_days_from_activity/tests/base.py on lines 93..106
    hr_worked_days_from_activity/tests/base.py on lines 110..123
    hr_worked_days_from_activity/tests/base.py on lines 127..140
    hr_worked_days_from_activity/tests/base.py on lines 186..199

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            self.ts_line5 = self.obj_ts_line.create(
            {
                "name": "Administrative",
                "user_id": self.employee.user_id.id,
                "date": (
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 4 other locations - About 5 hrs to fix
    hr_worked_days_from_activity/tests/base.py on lines 93..106
    hr_worked_days_from_activity/tests/base.py on lines 110..123
    hr_worked_days_from_activity/tests/base.py on lines 127..140
    hr_worked_days_from_activity/tests/base.py on lines 152..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            self.ts_line3 = self.obj_ts_line.create(
            {
                "name": "Administrative",
                "user_id": self.employee.user_id.id,
                "date": (
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 4 other locations - About 5 hrs to fix
    hr_worked_days_from_activity/tests/base.py on lines 93..106
    hr_worked_days_from_activity/tests/base.py on lines 110..123
    hr_worked_days_from_activity/tests/base.py on lines 152..165
    hr_worked_days_from_activity/tests/base.py on lines 186..199

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 90.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            self.payslip = self.env["hr.payslip"].create(
            {
                "employee_id": self.employee.id,
                "contract_id": self.contract.id,
                "date_from": self.date_from,
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 1 other location - About 1 hr to fix
    hr_worked_days_from_activity/tests/base.py on lines 203..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            self.payslip_2 = self.env["hr.payslip"].create(
            {
                "employee_id": self.employee.id,
                "contract_id": self.contract.id,
                "date_from": self.date_from_3,
    Severity: Major
    Found in hr_worked_days_from_activity/tests/base.py and 1 other location - About 1 hr to fix
    hr_worked_days_from_activity/tests/base.py on lines 169..174

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status