Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star

Showing 547 of 547 total issues

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_1 = self.obj_payslip.sudo(self.user_2).create(
            {
                "name": "Payslip 1",
                "employee_id": self.employee_2.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_viewer.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 20..25
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 158..163
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 265..270
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 61..66
hr_payslip_security/tests/test_payslip_viewer.py on lines 91..96
hr_payslip_security/tests/test_payslip_viewer.py on lines 119..124
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_8 = self.obj_payslip.sudo(self.user_2).create(
            {
                "name": "Payslip 8",
                "employee_id": self.employee_5.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_operator.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 20..25
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 265..270
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 21..26
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 61..66
hr_payslip_security/tests/test_payslip_viewer.py on lines 91..96
hr_payslip_security/tests/test_payslip_viewer.py on lines 119..124
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_3 = self.obj_payslip.sudo(self.user_1).create(
            {
                "name": "Payslip 3",
                "employee_id": self.employee_1.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_viewer.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 20..25
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 158..163
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 265..270
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 21..26
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 91..96
hr_payslip_security/tests/test_payslip_viewer.py on lines 119..124
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_5 = self.obj_payslip.sudo(self.user_4).create(
            {
                "name": "Payslip 5",
                "employee_id": self.employee_4.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_viewer.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 20..25
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 158..163
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 265..270
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 21..26
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 61..66
hr_payslip_security/tests/test_payslip_viewer.py on lines 119..124
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_1 = self.obj_payslip.sudo(self.user_1).create(
            {
                "name": "Payslip 1",
                "employee_id": self.employee_1.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_operator.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 158..163
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 265..270
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 21..26
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 61..66
hr_payslip_security/tests/test_payslip_viewer.py on lines 91..96
hr_payslip_security/tests/test_payslip_viewer.py on lines 119..124
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _prepare_contract_revert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def _prepare_contract_revert(self):
        self.ensure_one()
        return {
            "job_id": self.previous_job_id and self.previous_job_id.id or False,
            "working_hours": self.previous_working_hour_id
Severity: Minor
Found in hr_career_transition/models/hr_career_transition.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_13 = self.obj_payslip.sudo(self.user_8).create(
            {
                "name": "Payslip 13",
                "employee_id": self.employee_8.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_operator.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 20..25
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 158..163
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 21..26
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 61..66
hr_payslip_security/tests/test_payslip_viewer.py on lines 91..96
hr_payslip_security/tests/test_payslip_viewer.py on lines 119..124
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        wiz = self.wiz.with_context(active_id=[payslip_run.id]).create(
            {
                "data": self.get_file("test_import.csv"),
                "name": "test_import.csv",
                "delimeter": ",",
Severity: Major
Found in hr_payslip_import_input/tests/test_import.py and 2 other locations - About 1 hr to fix
hr_payslip_import_input/tests/test_import.py on lines 156..160
hr_payslip_import_input/tests/test_import.py on lines 185..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        wiz = self.wiz.with_context(active_id=[payslip_run.id]).create(
            {
                "data": self.get_file("test_import.csv"),
                "name": "test_import.csv",
                "delimeter": ",",
Severity: Major
Found in hr_payslip_import_input/tests/test_import.py and 2 other locations - About 1 hr to fix
hr_payslip_import_input/tests/test_import.py on lines 156..160
hr_payslip_import_input/tests/test_import.py on lines 206..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        wiz = self.wiz.with_context(active_id=[payslip_run.id]).create(
            {
                "data": self.get_file("import_error_1.xlsx"),
                "name": "import_error_1.xlsx",
                "delimeter": "",
Severity: Major
Found in hr_payslip_import_input/tests/test_import.py and 2 other locations - About 1 hr to fix
hr_payslip_import_input/tests/test_import.py on lines 185..189
hr_payslip_import_input/tests/test_import.py on lines 206..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

        payslip_6 = self.obj_payslip.sudo(self.user_4).create(
            {
                "name": "Payslip 6",
                "employee_id": self.employee_7.id,
                "date_from": self.date_from,
Severity: Major
Found in hr_payslip_security/tests/test_payslip_viewer.py and 15 other locations - About 1 hr to fix
hr_payslip_security/tests/test_payslip_operator.py on lines 20..25
hr_payslip_security/tests/test_payslip_operator.py on lines 95..100
hr_payslip_security/tests/test_payslip_operator.py on lines 158..163
hr_payslip_security/tests/test_payslip_operator.py on lines 178..183
hr_payslip_security/tests/test_payslip_operator.py on lines 244..249
hr_payslip_security/tests/test_payslip_operator.py on lines 265..270
hr_payslip_security/tests/test_payslip_operator.py on lines 286..291
hr_payslip_security/tests/test_payslip_operator.py on lines 315..320
hr_payslip_security/tests/test_payslip_viewer.py on lines 21..26
hr_payslip_security/tests/test_payslip_viewer.py on lines 42..47
hr_payslip_security/tests/test_payslip_viewer.py on lines 61..66
hr_payslip_security/tests/test_payslip_viewer.py on lines 91..96
hr_payslip_security/tests/test_payslip_viewer.py on lines 138..143
hr_payslip_security/tests/test_payslip_viewer.py on lines 168..173
hr_payslip_security/tests/test_payslip_viewer.py on lines 189..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    state = fields.Selection(
        string="State",
        selection=[
            ("draft", "Draft"),
            ("waiting", "In Progress"),
Severity: Major
Found in hr_employee_training_evaluation/models/hr_training_participant_evaluation.py and 1 other location - About 1 hr to fix
hr_employee_training_allowance/models/hr_training_participant_allowance.py on lines 67..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    state = fields.Selection(
        string="State",
        selection=[
            ("draft", "Draft"),
            ("confirm", "Waiting for Approval"),
Severity: Major
Found in hr_employee_training_allowance/models/hr_training_participant_allowance.py and 1 other location - About 1 hr to fix
hr_employee_training_evaluation/models/hr_training_participant_evaluation.py on lines 63..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function test_import_data has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test_import_data(self):
        # Generate Payslip
        vals = {
            "name": "Test Payslip",
            "date_end": time.strftime("%Y-%m-%d"),
Severity: Minor
Found in hr_payslip_import_input/tests/test_import.py - About 1 hr to fix

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange("company_id")
    def onchange_currency_id(self):
        self.currency_id = False
        if self.company_id:
            self.currency_id = self.company_id.currency_id
    Severity: Major
    Found in hr_dicipline_fine/models/hr_dicipline.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 56..60
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_contract_additional_field/models/hr_contract.py on lines 68..72
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_employee_training/models/hr_training_partisipant.py on lines 78..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange(
        "partisipant_id",
    )
    def onchange_organization_unit_id(self):
        self.organization_unit_id = False
    Severity: Major
    Found in hr_employee_training_organization_unit/models/hr_training_participant.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 56..60
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_contract_additional_field/models/hr_contract.py on lines 68..72
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
    hr_employee_training/models/hr_training_partisipant.py on lines 78..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange("employee_id")
    def onchange_manager_id(self):
        self.manager_id = False
        if self.employee_id:
            self.manager_id = self.employee_id.parent_id
    Severity: Major
    Found in hr_contract_additional_field/models/hr_contract.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 56..60
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
    hr_employee_training/models/hr_training_partisipant.py on lines 78..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange(
        "partisipant_id",
    )
    def onchange_job_id(self):
        self.job_id = False
    Severity: Major
    Found in hr_employee_training/models/hr_training_partisipant.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 56..60
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_contract_additional_field/models/hr_contract.py on lines 68..72
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange("employee_id")
    def onchange_company_id(self):
        self.company_id = False
        if self.employee_id:
            self.company_id = self.employee_id.company_id
    Severity: Major
    Found in hr_contract_additional_field/models/hr_contract.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_contract_additional_field/models/hr_contract.py on lines 68..72
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
    hr_employee_training/models/hr_training_partisipant.py on lines 78..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 307..311
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

        @api.onchange("schedule_id")
    def onchange_old_date_end(self):
        self.old_date_end = False
        if self.schedule_id:
            self.old_date_end = self.schedule_id.date_end
    Severity: Major
    Found in hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py and 16 other locations - About 1 hr to fix
    hr_award/models/hr_award.py on lines 378..382
    hr_contract_additional_field/models/hr_contract.py on lines 50..54
    hr_contract_additional_field/models/hr_contract.py on lines 56..60
    hr_contract_additional_field/models/hr_contract.py on lines 62..66
    hr_contract_additional_field/models/hr_contract.py on lines 68..72
    hr_dicipline/models/hr_dicipline.py on lines 376..380
    hr_dicipline_fine/models/hr_dicipline.py on lines 80..84
    hr_employee_training/models/hr_training_partisipant.py on lines 78..84
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 20..26
    hr_employee_training_job_family_modelling/models/hr_training_participant.py on lines 28..34
    hr_employee_training_organization_unit/models/hr_training.py on lines 22..28
    hr_employee_training_organization_unit/models/hr_training_participant.py on lines 16..22
    hr_expense_onchange/models/hr_expense.py on lines 11..15
    hr_expense_onchange/models/hr_expense.py on lines 17..21
    hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule_change.py on lines 301..305
    hr_timesheet_onchange/models/hr_analytic_timesheet.py on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 38.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language