Sign upLogin

open-synergy/opnsynid-hr

View on GitHub
Star

Showing 547 of 547 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_identification_from_home_address/models/hr_employee.py and 6 other locations - About 45 mins to fix
hr_career_transition/models/hr_contract.py on lines 0..12
hr_employee_language_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_project_experince_from_user/models/hr_employee.py on lines 0..11
hr_employee_skill_from_home_address/models/hr_employee.py on lines 0..11
hr_timesheet_computation/models/hr_contract.py on lines 0..11
hr_timesheet_computation_holiday/models/hr_timesheet_sheet.py on lines 0..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        if abs(1 - rounded_start_hour) < 0.01:
                            attendance_start = datetime(
                                attendance_start.year,
                                attendance_start.month,
                                attendance_start.day,
Severity: Minor
Found in hr_attendance_computation/models/hr_attendance.py and 1 other location - About 45 mins to fix
hr_attendance_computation/models/hr_attendance.py on lines 313..318

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

Severity: Major
Found in hr_career_transition/models/hr_contract.py and 6 other locations - About 45 mins to fix
hr_employee_identification_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_language_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_project_experince_from_user/models/hr_employee.py on lines 0..11
hr_employee_skill_from_home_address/models/hr_employee.py on lines 0..11
hr_timesheet_computation/models/hr_contract.py on lines 0..11
hr_timesheet_computation_holiday/models/hr_timesheet_sheet.py on lines 0..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        attendance_stop = datetime(
                            attendance_stop.year,
                            attendance_stop.month,
                            attendance_stop.day,
                            attendance_stop.hour,
Severity: Minor
Found in hr_attendance_computation/models/hr_attendance.py and 1 other location - About 45 mins to fix
hr_attendance_computation/models/hr_attendance.py on lines 298..311

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_skill_from_home_address/models/hr_employee.py and 6 other locations - About 45 mins to fix
hr_career_transition/models/hr_contract.py on lines 0..12
hr_employee_identification_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_language_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_project_experince_from_user/models/hr_employee.py on lines 0..11
hr_timesheet_computation/models/hr_contract.py on lines 0..11
hr_timesheet_computation_holiday/models/hr_timesheet_sheet.py on lines 0..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

Severity: Major
Found in hr_timesheet_computation/models/hr_contract.py and 6 other locations - About 45 mins to fix
hr_career_transition/models/hr_contract.py on lines 0..12
hr_employee_identification_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_language_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_project_experince_from_user/models/hr_employee.py on lines 0..11
hr_employee_skill_from_home_address/models/hr_employee.py on lines 0..11
hr_timesheet_computation_holiday/models/hr_timesheet_sheet.py on lines 0..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_language_from_home_address/models/hr_employee.py and 6 other locations - About 45 mins to fix
hr_career_transition/models/hr_contract.py on lines 0..12
hr_employee_identification_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_project_experince_from_user/models/hr_employee.py on lines 0..11
hr_employee_skill_from_home_address/models/hr_employee.py on lines 0..11
hr_timesheet_computation/models/hr_contract.py on lines 0..11
hr_timesheet_computation_holiday/models/hr_timesheet_sheet.py on lines 0..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_sequence_configurator/models/hr_employment_status.py and 7 other locations - About 45 mins to fix
hr_employee_birthdate_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_pob_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_training_allowance/models/hr_department.py on lines 0..11
hr_employee_training_allowance/models/hr_employee.py on lines 0..11
hr_employee_training_allowance/models/hr_job.py on lines 0..11
hr_employee_training_allowance/models/hr_training_category.py on lines 0..11
hr_expense_default_journal/models/hr_employee.py on lines 0..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_training_allowance/models/hr_employee.py and 7 other locations - About 45 mins to fix
hr_employee_birthdate_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_pob_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_sequence_configurator/models/hr_employment_status.py on lines 0..11
hr_employee_training_allowance/models/hr_department.py on lines 0..11
hr_employee_training_allowance/models/hr_job.py on lines 0..11
hr_employee_training_allowance/models/hr_training_category.py on lines 0..11
hr_expense_default_journal/models/hr_employee.py on lines 0..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function action_cancel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def action_cancel(self):
        for transition in self:
            if not transition._check_cant_cancel_latest_transition():
                msg = _("You can only cancel valid latest transition")
                raise UserError(msg)
Severity: Minor
Found in hr_career_transition/models/hr_career_transition.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_training_allowance/models/hr_training_category.py and 7 other locations - About 45 mins to fix
hr_employee_birthdate_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_pob_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_sequence_configurator/models/hr_employment_status.py on lines 0..11
hr_employee_training_allowance/models/hr_department.py on lines 0..11
hr_employee_training_allowance/models/hr_employee.py on lines 0..11
hr_employee_training_allowance/models/hr_job.py on lines 0..11
hr_expense_default_journal/models/hr_employee.py on lines 0..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_training_allowance/models/hr_job.py and 7 other locations - About 45 mins to fix
hr_employee_birthdate_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_pob_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_sequence_configurator/models/hr_employment_status.py on lines 0..11
hr_employee_training_allowance/models/hr_department.py on lines 0..11
hr_employee_training_allowance/models/hr_employee.py on lines 0..11
hr_employee_training_allowance/models/hr_training_category.py on lines 0..11
hr_expense_default_journal/models/hr_employee.py on lines 0..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_training_allowance/models/hr_department.py and 7 other locations - About 45 mins to fix
hr_employee_birthdate_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_pob_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_sequence_configurator/models/hr_employment_status.py on lines 0..11
hr_employee_training_allowance/models/hr_employee.py on lines 0..11
hr_employee_training_allowance/models/hr_job.py on lines 0..11
hr_employee_training_allowance/models/hr_training_category.py on lines 0..11
hr_expense_default_journal/models/hr_employee.py on lines 0..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

Severity: Major
Found in hr_employee_project_experince_from_user/models/hr_employee.py and 6 other locations - About 45 mins to fix
hr_career_transition/models/hr_contract.py on lines 0..12
hr_employee_identification_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_language_from_home_address/models/hr_employee.py on lines 0..11
hr_employee_skill_from_home_address/models/hr_employee.py on lines 0..11
hr_timesheet_computation/models/hr_contract.py on lines 0..11
hr_timesheet_computation_holiday/models/hr_timesheet_sheet.py on lines 0..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

    computation_ids = fields.One2many(
        string="Computations",
        comodel_name="hr.timesheet_computation",
        inverse_name="sheet_id",
        readonly=True,
Severity: Major
Found in hr_timesheet_computation/models/hr_timesheet_sheet.py and 17 other locations - About 40 mins to fix
hr_career_transition/models/hr_career_transition.py on lines 137..144
hr_career_transition/models/hr_career_transition.py on lines 149..156
hr_career_transition/models/hr_career_transition.py on lines 196..203
hr_career_transition/models/hr_career_transition.py on lines 208..215
hr_career_transition/models/hr_career_transition.py on lines 219..226
hr_career_transition/models/hr_career_transition.py on lines 230..237
hr_career_transition/models/hr_career_transition.py on lines 241..248
hr_career_transition/models/hr_career_transition.py on lines 252..259
hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
hr_employee_training/models/hr_training.py on lines 283..290
hr_employee_training/models/hr_training.py on lines 294..301
hr_employee_training_allowance/models/hr_training.py on lines 11..18
hr_employee_training_evaluation/models/hr_training.py on lines 35..42
hr_payslip_security/models/hr_payslip.py on lines 20..27
hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

    previous_contract_id = fields.Many2one(
        string="Previous Contract",
        comodel_name="hr.contract",
        ondelete="restrict",
        readonly=True,
Severity: Major
Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
hr_career_transition/models/hr_career_transition.py on lines 137..144
hr_career_transition/models/hr_career_transition.py on lines 196..203
hr_career_transition/models/hr_career_transition.py on lines 208..215
hr_career_transition/models/hr_career_transition.py on lines 219..226
hr_career_transition/models/hr_career_transition.py on lines 230..237
hr_career_transition/models/hr_career_transition.py on lines 241..248
hr_career_transition/models/hr_career_transition.py on lines 252..259
hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
hr_employee_training/models/hr_training.py on lines 283..290
hr_employee_training/models/hr_training.py on lines 294..301
hr_employee_training_allowance/models/hr_training.py on lines 11..18
hr_employee_training_evaluation/models/hr_training.py on lines 35..42
hr_payslip_security/models/hr_payslip.py on lines 20..27
hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Consider simplifying this complex logical expression.
Open

            if attn.start_attendance_id and attn.end_attendance_id:
                attn.state = "present"
            elif (attn.start_attendance_id and not attn.end_attendance_id) or (
                not attn.start_attendance_id and attn.end_attendance_id
            ):
Severity: Major
Found in hr_timesheet_attendance_schedule/models/hr_timesheet_attendance_schedule.py - About 40 mins to fix

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        department_id = fields.Many2one(
        string="Department",
        comodel_name="hr.department",
        ondelete="restrict",
        readonly=True,
    Severity: Major
    Found in hr_payslip_security/models/hr_payslip.py and 17 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 137..144
    hr_career_transition/models/hr_career_transition.py on lines 149..156
    hr_career_transition/models/hr_career_transition.py on lines 196..203
    hr_career_transition/models/hr_career_transition.py on lines 208..215
    hr_career_transition/models/hr_career_transition.py on lines 219..226
    hr_career_transition/models/hr_career_transition.py on lines 230..237
    hr_career_transition/models/hr_career_transition.py on lines 241..248
    hr_career_transition/models/hr_career_transition.py on lines 252..259
    hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
    hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
    hr_employee_training/models/hr_training.py on lines 283..290
    hr_employee_training/models/hr_training.py on lines 294..301
    hr_employee_training_allowance/models/hr_training.py on lines 11..18
    hr_employee_training_evaluation/models/hr_training.py on lines 35..42
    hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
    hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
    hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        reason_id = fields.Many2one(
        string="Reason",
        comodel_name="hr.career_transition_type_reason",
        ondelete="restrict",
        readonly=True,
    Severity: Major
    Found in hr_career_transition/models/hr_career_transition.py and 17 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 149..156
    hr_career_transition/models/hr_career_transition.py on lines 196..203
    hr_career_transition/models/hr_career_transition.py on lines 208..215
    hr_career_transition/models/hr_career_transition.py on lines 219..226
    hr_career_transition/models/hr_career_transition.py on lines 230..237
    hr_career_transition/models/hr_career_transition.py on lines 241..248
    hr_career_transition/models/hr_career_transition.py on lines 252..259
    hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
    hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
    hr_employee_training/models/hr_training.py on lines 283..290
    hr_employee_training/models/hr_training.py on lines 294..301
    hr_employee_training_allowance/models/hr_training.py on lines 11..18
    hr_employee_training_evaluation/models/hr_training.py on lines 35..42
    hr_payslip_security/models/hr_payslip.py on lines 20..27
    hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
    hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py on lines 15..22
    hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        attendance_schedule_ids = fields.One2many(
        string="Attendance Schedule",
        comodel_name="hr.timesheet_attendance_schedule",
        inverse_name="sheet_id",
        readonly=True,
    Severity: Major
    Found in hr_timesheet_attendance_schedule/models/hr_timesheet_sheet.py and 17 other locations - About 40 mins to fix
    hr_career_transition/models/hr_career_transition.py on lines 137..144
    hr_career_transition/models/hr_career_transition.py on lines 149..156
    hr_career_transition/models/hr_career_transition.py on lines 196..203
    hr_career_transition/models/hr_career_transition.py on lines 208..215
    hr_career_transition/models/hr_career_transition.py on lines 219..226
    hr_career_transition/models/hr_career_transition.py on lines 230..237
    hr_career_transition/models/hr_career_transition.py on lines 241..248
    hr_career_transition/models/hr_career_transition.py on lines 252..259
    hr_career_transition_payslip_input_policy/models/hr_career_transition.py on lines 12..19
    hr_career_transition_timesheet_computation/models/hr_career_transition.py on lines 12..19
    hr_employee_training/models/hr_training.py on lines 283..290
    hr_employee_training/models/hr_training.py on lines 294..301
    hr_employee_training_allowance/models/hr_training.py on lines 11..18
    hr_employee_training_evaluation/models/hr_training.py on lines 35..42
    hr_payslip_security/models/hr_payslip.py on lines 20..27
    hr_recruitment_request/models/hr_recruitment_request.py on lines 102..109
    hr_timesheet_computation/models/hr_timesheet_sheet.py on lines 11..18

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language