openSUSE/open-build-service

View on GitHub

Showing 574 of 632 total issues

File project.rb has 1205 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Project < ApplicationRecord
  include FlagHelper
  include Flag::Validations
  include CanRenderModel
  include HasRelationships
Severity: Major
Found in src/api/app/models/project.rb - About 3 days to fix

    Method create_expand_package has a Cognitive Complexity of 151 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_expand_package(packages, opts = {})
        newactions = []
        incident_suffix = ''
    
        # The maintenance ID is always the sub project name of the maintenance project
    Severity: Minor
    Found in src/api/app/models/bs_request_action.rb - About 3 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Project has 134 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Project < ApplicationRecord
      include FlagHelper
      include Flag::Validations
      include CanRenderModel
      include HasRelationships
    Severity: Major
    Found in src/api/app/models/project.rb - About 2 days to fix

      File package.rb has 1021 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'api_error'
      require 'builder/xchar'
      require 'rexml/document'
      
      # rubocop: disable Metrics/ClassLength
      Severity: Major
      Found in src/api/app/models/package.rb - About 2 days to fix

        File bs_request.rb has 946 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'xmlhash'
        
        include MaintenanceHelper
        
        # rubocop:disable Metrics/ClassLength
        Severity: Major
        Found in src/api/app/models/bs_request.rb - About 2 days to fix

          Class Package has 119 methods (exceeds 20 allowed). Consider refactoring.
          Open

          class Package < ApplicationRecord
            include FlagHelper
            include Flag::Validations
            include CanRenderModel
            include HasRelationships
          Severity: Major
          Found in src/api/app/models/package.rb - About 2 days to fix

            File source_controller.rb has 886 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            include MaintenanceHelper
            include ValidationHelper
            
            require 'builder/xchar'
            
            
            Severity: Major
            Found in src/api/app/controllers/source_controller.rb - About 2 days to fix

              Class User has 92 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class User < ApplicationRecord
                include CanRenderModel
              
                # Keep in sync with states defined in db/schema.rb
                STATES = ['unconfirmed', 'confirmed', 'locked', 'deleted', 'subaccount'].freeze
              Severity: Major
              Found in src/api/app/models/user.rb - About 1 day to fix

                File package_controller.rb has 727 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                class Webui::PackageController < Webui::WebuiController
                  include ParsePackageDiff
                  include Webui::PackageHelper
                  include Webui::ManageRelationships
                  include BuildLogSupport
                Severity: Major
                Found in src/api/app/controllers/webui/package_controller.rb - About 1 day to fix

                  File bs_request_action.rb has 694 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  class BsRequestAction < ApplicationRecord
                    #### Includes and extends
                    include ParsePackageDiff
                    include BsRequestAction::Errors
                    #### Constants
                  Severity: Major
                  Found in src/api/app/models/bs_request_action.rb - About 1 day to fix

                    File user.rb has 660 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require 'kconv'
                    require 'api_error'
                    
                    class User < ApplicationRecord
                      include CanRenderModel
                    Severity: Major
                    Found in src/api/app/models/user.rb - About 1 day to fix

                      Class SourceController has 79 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      class SourceController < ApplicationController
                        include Source::Errors
                      
                        validate_action index: { method: :get, response: :directory }
                        validate_action projectlist: { method: :get, response: :directory }
                      Severity: Major
                      Found in src/api/app/controllers/source_controller.rb - About 1 day to fix

                        Method webui_actions has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def webui_actions(opts = {})
                            # TODO: Fix!
                            actions = []
                            with_diff = opts.delete(:diffs)
                            bs_request_actions.each do |xml|
                        Severity: Minor
                        Found in src/api/app/models/bs_request.rb - About 1 day to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method create_branch_packages has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def create_branch_packages(tprj)
                            # collect also the needed repositories here
                            response = nil
                            @packages.each do |p|
                              pac = p[:package]
                        Severity: Minor
                        Found in src/api/app/models/branch_package.rb - About 1 day to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Class BsRequest has 69 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        class BsRequest < ApplicationRecord
                          include BsRequest::Errors
                          SEARCHABLE_FIELDS = [
                            'bs_requests.creator',
                            'bs_requests.priority',
                        Severity: Major
                        Found in src/api/app/models/bs_request.rb - About 1 day to fix

                          Method initialize has 225 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            def initialize
                              @lexer = REXML::Parsers::XPathParser.new
                          
                              @tables = {
                                'attribute' => 'attribs',
                          Severity: Major
                          Found in src/api/lib/xpath_engine.rb - About 1 day to fix

                            File xpath_engine.rb has 537 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            class XpathEngine
                              require 'rexml/parsers/xpathparser'
                            
                              class IllegalXpathError < APIError
                                setup 'illegal_xpath_error', 400
                            Severity: Major
                            Found in src/api/lib/xpath_engine.rb - About 1 day to fix

                              Method update_binary_releases_via_json has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
                              Open

                                def self.update_binary_releases_via_json(repository, json, time = Time.now)
                                  oldlist = where(repository: repository, obsolete_time: nil, modify_time: nil)
                                  # we can not just remove it from relation, delete would affect the object.
                                  processed_item = {}
                              
                              
                              Severity: Minor
                              Found in src/api/app/models/binary_release.rb - About 1 day to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              File project_controller.rb has 503 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              class Webui::ProjectController < Webui::WebuiController
                                include Webui::RequestHelper
                                include Webui::ProjectHelper
                                include Webui::ManageRelationships
                              
                              
                              Severity: Major
                              Found in src/api/app/controllers/webui/project_controller.rb - About 1 day to fix

                                Method check_action_permission! has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  def check_action_permission!(skip_source = nil)
                                    # find objects if specified or report error
                                    role = nil
                                    sprj = nil
                                    if person_name
                                Severity: Minor
                                Found in src/api/app/models/bs_request_action.rb - About 7 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language