Sign upLogin

openSUSE/open-build-service

View on GitHub
Star

Showing 335 of 425 total issues

Avoid deeply nested control flow statements.
Confirmed

          target.add_maintainer(@bs_request.creator) if target.can_be_modified_by?(User.possibly_nobody)
Severity: Minor
Found in src/api/app/controllers/webui/request_controller.rb - About 45 mins to fix

    Method write_to_backend has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

      def write_to_backend
    reset_cache
    raise ArgumentError, 'no commit_user set' unless commit_user
    raise InvalidParameterError, 'Project meta file can not be written via package model' if name == '_project'
    Severity: Minor
    Found in src/api/app/models/package.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_assignees has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

        def find_assignees(binary_name)
      projects = @rootproject.expand_all_projects

      # binary search via all projects
      data = Xmlhash.parse(Backend::Api::Search.binary(projects.map(&:name), binary_name))
    Severity: Minor
    Found in src/api/app/models/owner_search/assignee.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_from_xml has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

      def update_from_xml(xmlhash, ignore_lock = nil)
    check_write_access!(ignore_lock)

    Package.transaction do
      self.title = xmlhash.value('title')
    Severity: Minor
    Found in src/api/app/models/package.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_product_list has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

      def update_product_list
    # short cut to ensure that no products are left over
    unless is_product?
      products.destroy_all
      return
    Severity: Minor
    Found in src/api/app/models/package.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Confirmed

                unless allowed
              render_error status: 403, errorcode: 'execute_cmd_no_permission',
                           message: "No permission to execute command on package #{pack_name}"
              return
            end
    Severity: Minor
    Found in src/api/app/controllers/build_controller.rb - About 45 mins to fix

      Method update has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
      Open

        def update
    authorize @package, :update?
    @patchinfo = Patchinfo.new(patchinfo_params)
    if @patchinfo.valid?
      xml = @patchinfo.to_xml(@project, @package)
      Severity: Minor
      Found in src/api/app/controllers/webui/patchinfo_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Confirmed

              elsif @last_key && @attribs[table][@last_key][:double]
          @condition_values_needed.times { @condition_values << [value, value] }
        else
          @condition_values_needed.times { @condition_values << value }
      Severity: Minor
      Found in src/api/lib/xpath_engine.rb - About 45 mins to fix

        Method rpmlint_result has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Confirmed

          def rpmlint_result
    @repo_arch_hash = {}
    @buildresult = Buildresult.find_hashed(project: @project.to_param, package: @package.to_param, view: 'status')
    repos = [] # Temp var
    if @buildresult
        Severity: Minor
        Found in src/api/app/controllers/webui/package_controller.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method involved_packages_and_projects has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

            def involved_packages_and_projects
      involved_items = []
      roles = roles_to_filter

      involved_items.concat(involved_items_as_owner) if filter_by_owner?
        Severity: Minor
        Found in src/api/app/services/user_service/involved.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method show has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

          def show
    # FIXME: Remove this statement when scmsync is fully supported
    if @project.scmsync.present?
      flash[:error] = "Package sources for project #{@project.name} are received through scmsync.
                       This is not yet fully supported by the OBS frontend"
        Severity: Minor
        Found in src/api/app/controllers/webui/package_controller.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parse_one_diff has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

          def parse_one_diff(sourcediff)
    # Sort files into categories by their ending and add all of them to a hash. We
    # will later use the sorted and concatenated categories as key index into the per action file hash.
    changes_file_keys = []
    spec_file_keys = []
        Severity: Minor
        Found in src/api/app/mixins/parse_package_diff.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build_query_from_hash has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
        Open

            def self.build_query_from_hash(hash, key_list = nil)
      key_list ||= hash.keys
      query = key_list.map do |key|
        next unless hash.key?(key)
        Severity: Minor
        Found in src/api/app/lib/backend/connection.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                  if qtype == :predicate
            parse_predicate(root, stack[0])
            stack.shift
          elsif qtype.nil? || qtype == :qname
            # just a plain existence test
        Severity: Minor
        Found in src/api/lib/xpath_engine.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    raise IllegalXpathError, 'attributes must be $NAMESPACE:$NAME' if tvalues.size != 2
          Severity: Minor
          Found in src/api/lib/xpath_engine.rb - About 45 mins to fix

            Method raw_log_chunk has 6 arguments (exceeds 5 allowed). Consider refactoring.
            Open

              def raw_log_chunk(project, package_name, repo, arch, start, theend)
            Severity: Minor
            Found in src/api/app/mixins/build_log_support.rb - About 35 mins to fix

              Method info has 6 arguments (exceeds 5 allowed). Consider refactoring.
              Open

                  def self.info(method, host, port, path, response, start_time)
              Severity: Minor
              Found in src/api/app/lib/backend/logger.rb - About 35 mins to fix

                Method get_log_chunk has 6 arguments (exceeds 5 allowed). Consider refactoring.
                Open

                  def get_log_chunk(project, package_name, repo, arch, start, theend)
                Severity: Minor
                Found in src/api/app/mixins/build_log_support.rb - About 35 mins to fix

                  Method log_chunk has 6 arguments (exceeds 5 allowed). Consider refactoring.
                  Open

                          def self.log_chunk(project_name, package_name, repository_name, architecture_name, starting_line, ending_line)
                  Severity: Minor
                  Found in src/api/app/lib/backend/api/build_results/status.rb - About 35 mins to fix

                    Method branch has 6 arguments (exceeds 5 allowed). Consider refactoring.
                    Open

                            def self.branch(target_project, target_package, source_project, source_package, user, options = {})
                    Severity: Minor
                    Found in src/api/app/lib/backend/api/sources/package.rb - About 35 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language