Sign upLogin

openSUSE/open-build-service

View on GitHub
Star
src/api/app/models/staging/staged_requests.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
95%

Class StagedRequests has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class Staging::StagedRequests
  include ActiveModel::Model
  attr_accessor :request_numbers, :staging_project, :staging_workflow, :user_login

  def create
Severity: Minor
Found in src/api/app/models/staging/staged_requests.rb - About 2 hrs to fix

    Method destroy has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Wontfix

      def destroy
    requests = staging_workflow.target_of_bs_requests.where(number: request_numbers).joins(:bs_request_actions)
    requests.each do |request|
      staging_project = request.staging_project
      next unless unstageable?(request, staging_project)
    Severity: Minor
    Found in src/api/app/models/staging/staged_requests.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status