Sign upLogin

openaustralia/morph

View on GitHub
Star
app/controllers/api_controller.rb

Summary

Maintainability
C
1 day
Test Coverage
A
92%

File api_controller.rb has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class ApiController < ApplicationController
  extend T::Sig

  include ActionController::Live
Severity: Minor
Found in app/controllers/api_controller.rb - About 2 hrs to fix

    Method data_atom has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def data_atom(scraper, owner)
    params_query = T.cast(params[:query], String)

    # Only measuring the size of the entry blocks. We're ignoring the header.
    size = 0
    Severity: Minor
    Found in app/controllers/api_controller.rb - About 1 hr to fix

      Method data_json has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def data_json(scraper, owner)
    params_query = T.cast(params[:query], String)
    params_callback = T.cast(params[:callback], T.nilable(String))

    # When calculating the size here we're ignoring a few bytes at the front and end
      Severity: Minor
      Found in app/controllers/api_controller.rb - About 1 hr to fix

        Method data has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def data
    begin
      scraper = T.let(Scraper.friendly.find(params[:id]), Scraper)
    rescue ActiveRecord::RecordNotFound
      render_error "can't find scraper #{params[:id]}", 404
        Severity: Minor
        Found in app/controllers/api_controller.rb - About 1 hr to fix

          Method data_json has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def data_json(scraper, owner)
    params_query = T.cast(params[:query], String)
    params_callback = T.cast(params[:callback], T.nilable(String))

    # When calculating the size here we're ignoring a few bytes at the front and end
          Severity: Minor
          Found in app/controllers/api_controller.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def data
    begin
      scraper = T.let(Scraper.friendly.find(params[:id]), Scraper)
    rescue ActiveRecord::RecordNotFound
      render_error "can't find scraper #{params[:id]}", 404
          Severity: Minor
          Found in app/controllers/api_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method data_atom has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def data_atom(scraper, owner)
    params_query = T.cast(params[:query], String)

    # Only measuring the size of the entry blocks. We're ignoring the header.
    size = 0
          Severity: Minor
          Found in app/controllers/api_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status