Sign upLogin

openaustralia/morph

View on GitHub
Star
app/models/user.rb

Summary

Maintainability
A
3 hrs
Test Coverage
F
48%

Class User has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < Owner
  extend T::Sig

  devise :trackable, :rememberable, :omniauthable, omniauth_providers: [:github]
  has_many :organizations_users, dependent: :destroy
Severity: Minor
Found in app/models/user.rb - About 3 hrs to fix

    Method watched_broken_scrapers_ordered_by_urgency has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def watched_broken_scrapers_ordered_by_urgency
    watched_broken_scrapers.sort do |a, b|
      time_a = a.latest_successful_run_time
      time_b = b.latest_successful_run_time
      if time_b.nil? && time_a.nil?
    Severity: Minor
    Found in app/models/user.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status