Sign upLogin

opencontrol/compliance-masonry

View on GitHub
Star
pkg/cli/export/export_flatten.go

Summary

Maintainability
C
1 day
Test Coverage

Function flattenNormalize has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
Open

func flattenNormalize(config *Config, flattened *map[string]interface{}) error {
    // discover all controls
    var allControls []string

    // create the regex expressions we will use
Severity: Minor
Found in pkg/cli/export/export_flatten.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function flattenArray has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func flattenArray(config *Config, value interface{}, key string, flattened *map[string]interface{}) (bool, error) {
    // are we an array?
    input, okArray := value.([]interface{})
    if !okArray {
        return false, nil
Severity: Minor
Found in pkg/cli/export/export_flatten.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function flattenNormalize has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func flattenNormalize(config *Config, flattened *map[string]interface{}) error {
    // discover all controls
    var allControls []string

    // create the regex expressions we will use
Severity: Minor
Found in pkg/cli/export/export_flatten.go - About 1 hr to fix

    Function flattenArray has 58 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func flattenArray(config *Config, value interface{}, key string, flattened *map[string]interface{}) (bool, error) {
    // are we an array?
    input, okArray := value.([]interface{})
    if !okArray {
        return false, nil
    Severity: Minor
    Found in pkg/cli/export/export_flatten.go - About 1 hr to fix

      Function flattenDriver has 7 return statements (exceeds 4 allowed).
      Open

      func flattenDriver(config *Config, value interface{}, key string, flattened *map[string]interface{}) (bool, error) {
    // account for unset value - just ignore (?)
    if value == nil {
        log.Printf("flatten: No value for %s\n", key)
        return true, nil
      Severity: Major
      Found in pkg/cli/export/export_flatten.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status