Sign upLogin

opengovernment/askthem

View on GitHub
Star
app/controllers/questions_controller.rb

Summary

Maintainability
D
1 day
Test Coverage

Class QuestionsController has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

class QuestionsController < ApplicationController
  before_filter :force_http

  inherit_resources
  belongs_to :jurisdiction, parent_class: Metadatum, finder: :find_by_abbreviation, param: :jurisdiction
Severity: Minor
Found in app/controllers/questions_controller.rb - About 3 hrs to fix

    File questions_controller.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class QuestionsController < ApplicationController
  before_filter :force_http

  inherit_resources
  belongs_to :jurisdiction, parent_class: Metadatum, finder: :find_by_abbreviation, param: :jurisdiction
    Severity: Minor
    Found in app/controllers/questions_controller.rb - About 3 hrs to fix

      Method create has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def create
    @question = Question.new(params[:question])
    if @question.person_id.present?
      @person = @question.person
      @question.state = @person.state
      Severity: Minor
      Found in app/controllers/questions_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method show has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def show
    @user = user_signed_in? ? current_user : User.new
    if params[:code]
      confirmed_question = Question.where(id: params[:id])
                           .where(confirm_code: params[:code]).first
      Severity: Minor
      Found in app/controllers/questions_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create
    @question = Question.new(params[:question])
    if @question.person_id.present?
      @person = @question.person
      @question.state = @person.state
      Severity: Major
      Found in app/controllers/questions_controller.rb - About 2 hrs to fix

        Method show has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def show
    @user = user_signed_in? ? current_user : User.new
    if params[:code]
      confirmed_question = Question.where(id: params[:id])
                           .where(confirm_code: params[:code]).first
        Severity: Minor
        Found in app/controllers/questions_controller.rb - About 1 hr to fix

          Method new has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def new
    set_up_steps
    @question = Question.new(state: @state_code)
    @question.user = user_signed_in? ? current_user : User.new
    @question.user.for_new_question = true
          Severity: Minor
          Found in app/controllers/questions_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if question_different_jurisdiction
      correct_jurisdiction = question_different_jurisdiction.state
      if correct_jurisdiction == Metadatum::Unaffiliated::ABBREVIATION
        redirect_to unaffiliated_question_path(params[:id], share: params[:share])
      else
          Severity: Minor
          Found in app/controllers/questions_controller.rb and 1 other location - About 35 mins to fix
          app/controllers/people_controller.rb on lines 26..34

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status