Sign upLogin

opengovernment/askthem

View on GitHub
Star
app/models/cached_official.rb

Summary

Maintainability
D
1 day
Test Coverage

Method add_attributes_to has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def add_attributes_to(person)
    unless person.read_attribute(:ocd_division_id)
      person.write_attribute(:ocd_division_id, ocd_division_id)
    end
Severity: Minor
Found in app/models/cached_official.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File cached_official.rb has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class CachedOfficial
  include Mongoid::Document

  # The person's jurisdiction in askthem
  belongs_to :metadatum, foreign_key: "state"
Severity: Minor
Found in app/models/cached_official.rb - About 2 hrs to fix

    Method type has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def type
    @type ||=
      case office_level
      when "city", "other"
        case division_scope.downcase
    Severity: Minor
    Found in app/models/cached_official.rb - About 1 hr to fix

      Method add_attributes_to has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def add_attributes_to(person)
    unless person.read_attribute(:ocd_division_id)
      person.write_attribute(:ocd_division_id, ocd_division_id)
    end
      Severity: Minor
      Found in app/models/cached_official.rb - About 1 hr to fix

        Method copy_to_new_person has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def copy_to_new_person
    unless Metadatum.where(id: state).first
      copy_to_new_metadatum
    end
        Severity: Minor
        Found in app/models/cached_official.rb - About 1 hr to fix

          Method match_to_person has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def match_to_person
    if person_id.present?
      add_attributes_to(person)
      return person
    end
          Severity: Minor
          Found in app/models/cached_official.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method copy_to_new_person has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def copy_to_new_person
    unless Metadatum.where(id: state).first
      copy_to_new_metadatum
    end
          Severity: Minor
          Found in app/models/cached_official.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                unless person.read_attribute(:youtube_id)
        youtube_ids = channels.select { |c| c["type"] == "YouTube" }
          .map { |yt| yt["id"] }

        person.write_attribute(:youtube_id, youtube_ids.first)
          Severity: Minor
          Found in app/models/cached_official.rb and 1 other location - About 15 mins to fix
          app/models/cached_official.rb on lines 341..345

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                unless person.read_attribute(:facebook_id)
        facebook_ids = channels.select { |c| c["type"] == "Facebook" }
          .map { |fb| fb["id"] }

        person.write_attribute(:facebook_id, facebook_ids.first)
          Severity: Minor
          Found in app/models/cached_official.rb and 1 other location - About 15 mins to fix
          app/models/cached_official.rb on lines 348..352

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status