Sign upLogin

opengovernment/askthem

View on GitHub
Star
app/models/metadatum.rb

Summary

Maintainability
A
1 hr
Test Coverage

Consider simplifying this complex logical expression.
Open

      return session if session_details[session].key?("type") && session_details[session]["type"] == type ||
        type == "primary" && !session_details[session]["display_name"][/Budget|Called|Extraordinary|Fiscal|Special/] ||
        type == "special" &&  session_details[session]["display_name"][/Budget|Called|Extraordinary|Fiscal|Special/]
Severity: Major
Found in app/models/metadatum.rb - About 40 mins to fix

    Method most_recent_session has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def most_recent_session(type)
    session_details = read_attribute(:session_details)
    read_attribute(:terms).last["sessions"].reverse.each do |session|
      # OpenStates doesn't always declare the session type.
      return session if session_details[session].key?("type") && session_details[session]["type"] == type ||
    Severity: Minor
    Found in app/models/metadatum.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status