Sign upLogin

opengovernment/askthem

View on GitHub
Star
app/models/project_vote_smart_person_detail.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method person_match_official? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def person_match_official?(person, official)
    return false unless district_or_office_for(person) ==
      pvs_district_or_office_for(official)

    return false unless NameComparison.new(comparable_family_name_for(person),
Severity: Minor
Found in app/models/project_vote_smart_person_detail.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method district_or_office_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def district_or_office_for(person)
    district_or_office = person['district']

    # reset if federal
    if person.state == 'us'
Severity: Minor
Found in app/models/project_vote_smart_person_detail.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status