Sign upLogin

opengovernment/askthem

View on GitHub
Star
lib/project_vote_smart.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method get has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def get(endpoint, params = {})
    begin
      result = JSON.parse(RestClient.get("http://api.votesmart.org/#{endpoint}", params: params.merge(key: @api_key, o: 'JSON')))

      if result['error']
Severity: Minor
Found in lib/project_vote_smart.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get(endpoint, params = {})
    begin
      result = JSON.parse(RestClient.get("http://api.votesmart.org/#{endpoint}", params: params.merge(key: @api_key, o: 'JSON')))

      if result['error']
Severity: Minor
Found in lib/project_vote_smart.rb - About 1 hr to fix

    Method officials_by_state_and_office has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def officials_by_state_and_office(state_id, office_ids)
    office_ids.each_with_index do |office_id, index|
      begin
        state_id = state_id == 'us' ? 'NA' : state_id.upcase
        return get('Officials.getByOfficeState',
    Severity: Minor
    Found in lib/project_vote_smart.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method office_ids has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def office_ids(options)
    # Chairman, Councilmember
    return [347, 368] if options[:state] == 'dc'

    office_ids = []
    Severity: Minor
    Found in lib/project_vote_smart.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status