openimis/openimis-be-api_fhir_py

View on GitHub
api_fhir/configurations/__init__.py

Summary

Maintainability
B
5 hrs
Test Coverage

File __init__.py has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import sys


class BaseConfiguration(object):  # pragma: no cover

Severity: Minor
Found in api_fhir/configurations/__init__.py - About 3 hrs to fix

    EligibilityConfiguration has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class EligibilityConfiguration(BaseConfiguration):  # pragma: no cover
    
        @classmethod
        def build_configuration(cls, cfg):
            raise NotImplementedError('`build_configuration()` must be implemented.')
    Severity: Minor
    Found in api_fhir/configurations/__init__.py - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

      class CommunicationRequestConfiguration(BaseConfiguration):  # pragma: no cover
      
          @classmethod
          def build_configuration(cls, cfg):
              raise NotImplementedError('`build_configuration()` must be implemented.')
      Severity: Major
      Found in api_fhir/configurations/__init__.py and 1 other location - About 5 hrs to fix
      api_fhir/configurations/__init__.py on lines 105..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

      class IssueTypeConfiguration(BaseConfiguration):  # pragma: no cover
      
          @classmethod
          def build_configuration(cls, cfg):
              raise NotImplementedError('`build_configuration()` must be implemented.')
      Severity: Major
      Found in api_fhir/configurations/__init__.py and 1 other location - About 5 hrs to fix
      api_fhir/configurations/__init__.py on lines 278..302

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status