Sign upLogin

openjaf/cenit

View on GitHub
Star
app/models/concerns/setup/authorization_handler.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method check_authorization has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def check_authorization
      if using_authorization.present?
        field = authorization_handler ? :template_parameters : :headers
        auth_params = using_authorization.class.send("auth_#{field}")
        conflicting_keys = send(field).select { |p| auth_params.key?(p.key) }.collect(&:key)
Severity: Minor
Found in app/models/concerns/setup/authorization_handler.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method inject_template_parameters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def inject_template_parameters(hash)
      using_authorization.each_template_parameter do |key, value|
        hash[key] = value unless hash.key?(key) && authorization_handler
      end if using_authorization
    end
Severity: Minor
Found in app/models/concerns/setup/authorization_handler.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status