File webhook_common.rb
has 587 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'net/ftp'
module Setup
module WebhookCommon
extend ActiveSupport::Concern
Method submit
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
def submit(*args, &block)
if (options = args[0]).is_a?(Hash)
body_argument = options[:body]
else
body_argument = options
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_http_connection
has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring. Open
def process_http_connection(connection, template_parameters, verbose_response, last_response, options, &block)
template_parameters[:method] ||= method
conformed_url = template_parameters[:url]
conformed_path = template_parameters[:path]
parameters = connection.conformed_parameters(template_parameters)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_http_connection
has 135 lines of code (exceeds 25 allowed). Consider refactoring. Open
def process_http_connection(connection, template_parameters, verbose_response, last_response, options, &block)
template_parameters[:method] ||= method
conformed_url = template_parameters[:url]
conformed_path = template_parameters[:path]
parameters = connection.conformed_parameters(template_parameters)
Method process_connection
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
def process_connection(template_parameters, verbose_response, last_response, options, &block)
conformed_url = template_parameters[:url]
conformed_path = template_parameters[:path]
body = template_parameters[:body]
halt_anyway = false
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_connection
has 96 lines of code (exceeds 25 allowed). Consider refactoring. Open
def process_connection(template_parameters, verbose_response, last_response, options, &block)
conformed_url = template_parameters[:url]
conformed_path = template_parameters[:path]
body = template_parameters[:body]
halt_anyway = false
Method connections
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
def connections
if @connections_cache
@connections_cache
else
connections =
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method submit
has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
def submit(*args, &block)
if (options = args[0]).is_a?(Hash)
body_argument = options[:body]
else
body_argument = options
Method process_ldap_uri
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
def process_ldap_uri(uri, template_parameters, options)
username, password = check(template_parameters, :username, :password)
auth_method = (template_parameters['auth_method'].presence || 'simple').to_sym
Method build_attachment
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def build_attachment(hash)
unless hash.key?(:filename)
filename = hash[:base_name] || DateTime.now.strftime('%Y-%m-%d_%Hh%Mm%S')
if (content_type = hash[:contentType]) && (types = ::MIME::Types[content_type])
types.each do |type|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_ftp
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def process_ftp(opts)
result = nil
path = URI.decode(opts[:path])
username, password = check(opts[:template_parameters], :username, :password)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method process_ftp
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def process_ftp(opts)
result = nil
path = URI.decode(opts[:path])
username, password = check(opts[:template_parameters], :username, :password)
Avoid deeply nested control flow statements. Open
if content.is_a?(String) || content.respond_to?(:read)
content
elsif content.is_a?(Hash)
UploadIO.new(StringIO.new(content[:data]), content[:contentType], content[:filename])
else
Method process_http_connection
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def process_http_connection(connection, template_parameters, verbose_response, last_response, options, &block)
Method process_connection
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def process_connection(template_parameters, verbose_response, last_response, options, &block)
Similar blocks of code found in 2 locations. Consider refactoring. Open
notification_model.create_with(
message: { response_code: response.code }.to_json,
type: response.success? ? :notice : :error,
attachment: attachment_from(response),
skip_notification_level: options[:skip_notification_level] || options[:notify_response]
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 26.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
notification_model.create_with(
message: { response_code: http_response.code }.to_json,
type: http_response.success? ? :notice : :error,
attachment: attachment_from(http_response),
skip_notification_level: options[:skip_notification_level] || options[:notify_response]
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 26.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76